Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1515843003: Revert of Flip linux blink bots to GN. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
CC:
chromium-reviews, ojan, peria
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_blink_bots_to_mb_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip linux blink bots to GN. (patchset #2 id:20001 of https://codereview.chromium.org/1512803002/ ) Reason for revert: Looks like this broke linux_blink_rel, see http://crbug.com/568582 Original issue's description: > Flip linux blink bots to GN. > > This flips the regular bots, leak bots, and oilpan bots to GN, > but not the ASAN and MSAN bots. > > R=haraken@chromium.org, phajdan.jr@chromium.org > BUG=432959 > > Committed: https://crrev.com/f6bce52dc0ec0f84660aa4e62906b63366e33805 > Cr-Commit-Position: refs/heads/master@{#364236} TBR=phajdan.jr@chromium.org,haraken@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=432959 Committed: https://crrev.com/ded9423c64c3708d7c826b4eb69bfb921ddc8bf2 Cr-Commit-Position: refs/heads/master@{#364362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -23 lines) Patch
M tools/mb/mb_config.pyl View 4 chunks +15 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
Created Revert of Flip linux blink bots to GN.
5 years ago (2015-12-10 15:15:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515843003/1
5 years ago (2015-12-10 15:16:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 15:17:54 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ded9423c64c3708d7c826b4eb69bfb921ddc8bf2 Cr-Commit-Position: refs/heads/master@{#364362}
5 years ago (2015-12-10 15:18:33 UTC) #5
Dirk Pranke
5 years ago (2015-12-10 17:16:04 UTC) #6
Message was sent while issue was closed.
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698