 Chromium Code Reviews
 Chromium Code Reviews Issue 1515833004:
  Add missing data_deps to webkit_unit_tests  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1515833004:
  Add missing data_deps to webkit_unit_tests  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/Source/web/BUILD.gn | 
| diff --git a/third_party/WebKit/Source/web/BUILD.gn b/third_party/WebKit/Source/web/BUILD.gn | 
| index caa4ea1eb21a6d432909e91be57dd4beb3b781f4..01134194fd73b6b93d4e65511863c38a17b2e8ff 100644 | 
| --- a/third_party/WebKit/Source/web/BUILD.gn | 
| +++ b/third_party/WebKit/Source/web/BUILD.gn | 
| @@ -106,6 +106,20 @@ group("webkit_unit_tests_run") { | 
| ] | 
| } | 
| +group("webkit_unit_tests_data") { | 
| + data = [ | 
| + "tests/data/", | 
| + "../core/paint/test_data/", | 
| 
Dirk Pranke
2015/12/10 17:28:36
nit: these should be src-relative paths, like //th
 | 
| + | 
| + # Required by some image decoder tests. | 
| + "../platform/image-decoders/testing/", | 
| + "../../LayoutTests/fast/images/resources/", | 
| + | 
| + # Required by some font tests. | 
| + "../platform/testing/data/", | 
| + ] | 
| +} | 
| + | 
| # GYP version: WebKit/Source/web/web_tests.gyp:webkit_unit_tests | 
| test("webkit_unit_tests") { | 
| visibility = [] # Allow re-assignment of list. | 
| @@ -129,6 +143,11 @@ test("webkit_unit_tests") { | 
| "//v8", | 
| ] | 
| + data_deps = [ | 
| + "//content/shell:pak", | 
| + ":webkit_unit_tests_data", | 
| 
Dirk Pranke
2015/12/10 17:28:36
and the presubmit check should've complained that
 | 
| + ] | 
| + | 
| sources = [ | 
| "tests/RunAllTests.cpp", | 
| ] |