Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1511073002: DevTools: [SASS] introduce sass module, implement SCSS AST-builder. (Closed)

Created:
5 years ago by lushnikov
Modified:
5 years ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SASS] introduce sass module, implement SCSS AST-builder. The patch introduces "sass" module which will be responsible for all SASS-processing in DevTools. The patch also adds a simple SCSS AST-builder, which is capable of parsing variables, mixins and properties. BUG=527993 R=pfeldman, dgozman Committed: https://crrev.com/c85e962a63be9b75b51eb71218725fbf21d2b7c6 Cr-Commit-Position: refs/heads/master@{#364206}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : address comments #

Patch Set 4 : introduce ASTDocument #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1068 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/inspector/sass/sass-test.js View 1 2 3 1 chunk +90 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-1.html View 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-1-expected.txt View 1 chunk +97 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-2.html View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-2-expected.txt View 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-3.html View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-3-expected.txt View 1 chunk +75 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-4.html View 1 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-4-expected.txt View 1 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-5.html View 1 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-5-expected.txt View 1 1 chunk +48 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gypi View 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/TextRange.js View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js View 1 2 3 1 chunk +335 lines, -0 lines 2 comments Download
A third_party/WebKit/Source/devtools/front_end/sass/module.json View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (2 generated)
lushnikov
ptal
5 years ago (2015-12-09 03:30:25 UTC) #1
pfeldman
https://codereview.chromium.org/1511073002/diff/20001/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js File third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js (right): https://codereview.chromium.org/1511073002/diff/20001/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js#newcode78 third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js:78: // The |processToken| is called per-line, so no token ...
5 years ago (2015-12-09 03:50:59 UTC) #2
lushnikov
https://codereview.chromium.org/1511073002/diff/20001/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js File third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js (right): https://codereview.chromium.org/1511073002/diff/20001/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js#newcode205 third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js:205: this.parent = null; On 2015/12/09 03:50:59, pfeldman wrote: > ...
5 years ago (2015-12-09 07:04:57 UTC) #3
lushnikov
addressed comments, added faster root() calculation
5 years ago (2015-12-09 18:40:19 UTC) #4
lushnikov
introduced ASTDocument instead of root()
5 years ago (2015-12-09 19:58:11 UTC) #5
pfeldman
lgtm https://codereview.chromium.org/1511073002/diff/60001/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js File third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js (right): https://codereview.chromium.org/1511073002/diff/60001/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js#newcode228 third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js:228: this.text = text; Why is text necessary? You ...
5 years ago (2015-12-09 20:13:43 UTC) #6
lushnikov
https://codereview.chromium.org/1511073002/diff/60001/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js File third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js (right): https://codereview.chromium.org/1511073002/diff/60001/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js#newcode228 third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js:228: this.text = text; On 2015/12/09 20:13:43, pfeldman wrote: > ...
5 years ago (2015-12-09 21:41:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511073002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511073002/60001
5 years ago (2015-12-09 21:46:18 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-09 23:19:23 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-09 23:20:57 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c85e962a63be9b75b51eb71218725fbf21d2b7c6
Cr-Commit-Position: refs/heads/master@{#364206}

Powered by Google App Engine
This is Rietveld 408576698