Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1515673004: remove duplicate friend declaration (Closed)

Created:
5 years ago by Mostyn Bramley-Moore
Modified:
5 years ago
Reviewers:
Ian Vollick, tdresser
CC:
chromium-reviews, danakj, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, blink-layers+watch_chromium.org, Rik, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, Stephen Chennney, krit, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove duplicate friend declaration GCC builds fail with duplicate friend declaration introduced by https://codereview.chromium.org/1407383005 BUG=543655 TBR=vollick Committed: https://crrev.com/f0d0b79e2b68e795e71f293e700305948d37cbca Cr-Commit-Position: refs/heads/master@{#364328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515673004/1
5 years ago (2015-12-10 08:28:51 UTC) #2
Mostyn Bramley-Moore
@vollick: PTAL at this GCC build fixup.
5 years ago (2015-12-10 08:28:54 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-10 10:37:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515673004/1
5 years ago (2015-12-10 10:40:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 10:45:12 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f0d0b79e2b68e795e71f293e700305948d37cbca Cr-Commit-Position: refs/heads/master@{#364328}
5 years ago (2015-12-10 10:46:07 UTC) #14
tdresser
5 years ago (2015-12-10 13:22:24 UTC) #15
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698