Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1515613006: Merge to XFA: Replace several more CFX_MapPtrToPtr with std::set or std::map (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Replace several more CFX_MapPtrToPtr with std::set or std::map Original Review URL: https://codereview.chromium.org/1520643002 . (cherry picked from commit 7db2a535f163e7ce5995da12161ebd0214f0f75a) Original Review URL: https://codereview.chromium.org/1511413008 . (cherry picked from commit 168cfb7ee0f2abbd2bddb7e7d8b430a6d8c6c120) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d2cfdd5c72be670aff556c44aaff53df66b23ea6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -93 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 2 chunks +4 lines, -1 line 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 1 chunk +1 line, -4 lines 0 comments Download
M core/include/fxge/fx_font.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +8 lines, -14 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 1 chunk +6 lines, -7 lines 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 2 chunks +7 lines, -11 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 6 chunks +37 lines, -49 lines 0 comments Download
M core/src/fxge/ge/text_int.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR, automatic merge.
5 years ago (2015-12-10 23:37:43 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as d2cfdd5c72be670aff556c44aaff53df66b23ea6 (presubmit successful).
5 years ago (2015-12-10 23:39:33 UTC) #3
Lei Zhang
5 years ago (2015-12-10 23:45:53 UTC) #4
Message was sent while issue was closed.
rs lgtm

Powered by Google App Engine
This is Rietveld 408576698