Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1520643002: Replace several more CFX_MapPtrToPtr with std::set or std::map (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace several more CFX_MapPtrToPtr with std::set or std::map R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7db2a535f163e7ce5995da12161ebd0214f0f75a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -87 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 2 chunks +4 lines, -1 line 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 1 chunk +1 line, -4 lines 0 comments Download
M core/include/fxge/fx_font.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 2 chunks +4 lines, -4 lines 1 comment Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +8 lines, -14 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 1 chunk +6 lines, -7 lines 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 2 chunks +7 lines, -11 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 4 chunks +31 lines, -43 lines 0 comments Download
M core/src/fxge/ge/text_int.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, more background cleanup work.
5 years ago (2015-12-10 21:54:01 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1520643002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right): https://codereview.chromium.org/1520643002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp#newcode288 core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:288: if (bDirect && visited->find(obj_num) == visited->end()) { Someday ...
5 years ago (2015-12-10 22:28:03 UTC) #3
Tom Sepez
5 years ago (2015-12-10 23:03:21 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7db2a535f163e7ce5995da12161ebd0214f0f75a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698