Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1515603002: PPC64: [turbofan] Changed TruncateFloat64ToInt64 to TryTruncateFloat64ToInt64. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC64: [turbofan] Changed TruncateFloat64ToInt64 to TryTruncateFloat64ToInt64. Port 95844d94f3336489403c7f2d70c6ea01a0cf3002 Original commit message: The new operator provides a second output which indicates whether the conversion from float64 to int64 was successful or not. The second output returns 0 if the conversion fails. If the conversion succeeds, then the second output is differs from 0. The second output can be ignored, which means that the operator can be used the same way as the original operator. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/b9f92c15d6eda111392e9498dc9b81b6df12d1c5 Cr-Commit-Position: refs/heads/master@{#32724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -20 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +22 lines, -2 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +12 lines, -4 lines 0 comments Download
M src/ppc/assembler-ppc.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/ppc/assembler-ppc.cc View 2 chunks +18 lines, -1 line 0 comments Download
M src/ppc/constants-ppc.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/ppc/disasm-ppc.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/ppc/simulator-ppc.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 7 chunks +65 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515603002/1
5 years ago (2015-12-09 16:25:59 UTC) #2
MTBrandyberry
5 years ago (2015-12-09 16:26:01 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-09 17:05:16 UTC) #5
john.yan
lgtm
5 years ago (2015-12-09 18:12:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515603002/1
5 years ago (2015-12-09 18:18:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 18:29:25 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-09 18:30:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9f92c15d6eda111392e9498dc9b81b6df12d1c5
Cr-Commit-Position: refs/heads/master@{#32724}

Powered by Google App Engine
This is Rietveld 408576698