Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 1515513002: [turbofan] Also lower JSCreateCatchContext in typed lowering. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Also lower JSCreateCatchContext in typed lowering. R=jarin@chromium.org Committed: https://crrev.com/82fd004745204f313e0a1605d3e9cdaf759d61ff Cr-Commit-Position: refs/heads/master@{#32709}

Patch Set 1 #

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +30 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 1 chunk +23 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
Benedikt Meurer
5 years ago (2015-12-09 10:26:27 UTC) #1
Benedikt Meurer
Hey Jaro, Simple patch to bring catch context in line with the rest. Please take ...
5 years ago (2015-12-09 10:27:19 UTC) #2
Jarin
lgtm (although the bots seem to be a bit depressed from your change).
5 years ago (2015-12-09 10:40:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515513002/20001
5 years ago (2015-12-09 10:47:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11210)
5 years ago (2015-12-09 11:07:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515513002/20001
5 years ago (2015-12-09 11:33:32 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-09 11:51:53 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-09 11:52:30 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82fd004745204f313e0a1605d3e9cdaf759d61ff
Cr-Commit-Position: refs/heads/master@{#32709}

Powered by Google App Engine
This is Rietveld 408576698