Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1508373002: [turbofan] The JSCreateWithContext operator doesn't need a frame state. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@JSCreateCatchContext
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] The JSCreateWithContext operator doesn't need a frame state. Creating a with context cannot lazy/eager deoptimize, so we don't need to pass a frame state. R=jarin@chromium.org Committed: https://crrev.com/6a1328452ac472f7664e9d2ceb652eed39f56286 Cr-Commit-Position: refs/heads/master@{#32711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M src/compiler/operator-properties.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/compiler/js-context-relaxation-unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Benedikt Meurer
5 years ago (2015-12-09 10:54:55 UTC) #1
Benedikt Meurer
Hey Jaro, Simple cleanup. Please take a look. Thanks, Benedikt
5 years ago (2015-12-09 10:55:46 UTC) #2
Jarin
lgtm
5 years ago (2015-12-09 11:29:07 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1515513002 Patch 20001). Please resolve the dependency and ...
5 years ago (2015-12-09 11:32:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508373002/1
5 years ago (2015-12-09 11:58:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 12:00:11 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-09 12:00:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a1328452ac472f7664e9d2ceb652eed39f56286
Cr-Commit-Position: refs/heads/master@{#32711}

Powered by Google App Engine
This is Rietveld 408576698