media/cast/net/rtp/frame_buffer_unittest.cc - Issue 1515433002: Replace uses of raw uint32's with a type-checked RtpTimeTicks data type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/net/rtp/frame_buffer_unittest.cc

Issue 1515433002: Replace uses of raw uint32's with a type-checked RtpTimeTicks data type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Speculative workaround fix for win8_chromium_ng compile error. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/cast/net/rtp/frame_buffer_unittest.cc

diff --git a/media/cast/net/rtp/frame_buffer_unittest.cc b/media/cast/net/rtp/frame_buffer_unittest.cc

index cb3f416bdd403f32e2b87506b932ccc8a77e65a0..7735aed5e5216722f71bfc56b47b514ab4f0781c 100644

--- a/media/cast/net/rtp/frame_buffer_unittest.cc

+++ b/media/cast/net/rtp/frame_buffer_unittest.cc

@@ -28,7 +28,7 @@ class FrameBufferTest : public ::testing::Test {

};

TEST_F(FrameBufferTest, OnePacketInsertSanity) {

- rtp_header_.rtp_timestamp = 3000;

+ rtp_header_.rtp_timestamp = RtpTimeTicks().Expand(UINT32_C(3000));

rtp_header_.is_key_frame = true;

rtp_header_.frame_id = 5;

rtp_header_.reference_frame_id = 5;

@@ -38,7 +38,7 @@ TEST_F(FrameBufferTest, OnePacketInsertSanity) {

EXPECT_EQ(EncodedFrame::KEY, frame.dependency);

EXPECT_EQ(5u, frame.frame_id);

EXPECT_EQ(5u, frame.referenced_frame_id);

- EXPECT_EQ(3000u, frame.rtp_timestamp);

+ EXPECT_EQ(3000u, frame.rtp_timestamp.lower_32_bits());

}

TEST_F(FrameBufferTest, EmptyBuffer) {

« no previous file with comments | « media/cast/net/rtp/frame_buffer.h ('k') | media/cast/net/rtp/receiver_stats.h » ('j') | no next file with comments »