Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: media/cast/net/rtp/frame_buffer_unittest.cc

Issue 1515433002: Replace uses of raw uint32's with a type-checked RtpTimeTicks data type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Speculative workaround fix for win8_chromium_ng compile error. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/cast/net/rtp/frame_buffer.h ('k') | media/cast/net/rtp/receiver_stats.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "media/cast/net/cast_transport_defines.h" 8 #include "media/cast/net/cast_transport_defines.h"
9 #include "media/cast/net/rtp/frame_buffer.h" 9 #include "media/cast/net/rtp/frame_buffer.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 10 matching lines...) Expand all
21 ~FrameBufferTest() override {} 21 ~FrameBufferTest() override {}
22 22
23 FrameBuffer buffer_; 23 FrameBuffer buffer_;
24 std::vector<uint8_t> payload_; 24 std::vector<uint8_t> payload_;
25 RtpCastHeader rtp_header_; 25 RtpCastHeader rtp_header_;
26 26
27 DISALLOW_COPY_AND_ASSIGN(FrameBufferTest); 27 DISALLOW_COPY_AND_ASSIGN(FrameBufferTest);
28 }; 28 };
29 29
30 TEST_F(FrameBufferTest, OnePacketInsertSanity) { 30 TEST_F(FrameBufferTest, OnePacketInsertSanity) {
31 rtp_header_.rtp_timestamp = 3000; 31 rtp_header_.rtp_timestamp = RtpTimeTicks().Expand(UINT32_C(3000));
32 rtp_header_.is_key_frame = true; 32 rtp_header_.is_key_frame = true;
33 rtp_header_.frame_id = 5; 33 rtp_header_.frame_id = 5;
34 rtp_header_.reference_frame_id = 5; 34 rtp_header_.reference_frame_id = 5;
35 buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_); 35 buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_);
36 EncodedFrame frame; 36 EncodedFrame frame;
37 EXPECT_TRUE(buffer_.AssembleEncodedFrame(&frame)); 37 EXPECT_TRUE(buffer_.AssembleEncodedFrame(&frame));
38 EXPECT_EQ(EncodedFrame::KEY, frame.dependency); 38 EXPECT_EQ(EncodedFrame::KEY, frame.dependency);
39 EXPECT_EQ(5u, frame.frame_id); 39 EXPECT_EQ(5u, frame.frame_id);
40 EXPECT_EQ(5u, frame.referenced_frame_id); 40 EXPECT_EQ(5u, frame.referenced_frame_id);
41 EXPECT_EQ(3000u, frame.rtp_timestamp); 41 EXPECT_EQ(3000u, frame.rtp_timestamp.lower_32_bits());
42 } 42 }
43 43
44 TEST_F(FrameBufferTest, EmptyBuffer) { 44 TEST_F(FrameBufferTest, EmptyBuffer) {
45 EXPECT_FALSE(buffer_.Complete()); 45 EXPECT_FALSE(buffer_.Complete());
46 EncodedFrame frame; 46 EncodedFrame frame;
47 EXPECT_FALSE(buffer_.AssembleEncodedFrame(&frame)); 47 EXPECT_FALSE(buffer_.AssembleEncodedFrame(&frame));
48 } 48 }
49 49
50 TEST_F(FrameBufferTest, DefaultOnePacketFrame) { 50 TEST_F(FrameBufferTest, DefaultOnePacketFrame) {
51 buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_); 51 buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_);
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_); 85 buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_);
86 EXPECT_FALSE(buffer_.Complete()); 86 EXPECT_FALSE(buffer_.Complete());
87 // Insert missing packet. 87 // Insert missing packet.
88 rtp_header_.packet_id = 2; 88 rtp_header_.packet_id = 2;
89 buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_); 89 buffer_.InsertPacket(&payload_[0], payload_.size(), rtp_header_);
90 EXPECT_TRUE(buffer_.Complete()); 90 EXPECT_TRUE(buffer_.Complete());
91 } 91 }
92 92
93 } // namespace media 93 } // namespace media
94 } // namespace cast 94 } // namespace cast
OLDNEW
« no previous file with comments | « media/cast/net/rtp/frame_buffer.h ('k') | media/cast/net/rtp/receiver_stats.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698