Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: media/cast/cast_defines.h

Issue 1515433002: Replace uses of raw uint32's with a type-checked RtpTimeTicks data type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed mkwst's comments, plus REBASE. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/cast_defines.h
diff --git a/media/cast/cast_defines.h b/media/cast/cast_defines.h
index 68607977ecb287c6cff2df5814ce298af1760ae7..9eab12225eb746b23b5d76b5870f833dac07ac6d 100644
--- a/media/cast/cast_defines.h
+++ b/media/cast/cast_defines.h
@@ -18,11 +18,6 @@ inline bool IsNewerFrameId(uint32 frame_id, uint32 prev_frame_id) {
static_cast<uint32>(frame_id - prev_frame_id) < 0x80000000;
}
-inline bool IsNewerRtpTimestamp(uint32 timestamp, uint32 prev_timestamp) {
- return (timestamp != prev_timestamp) &&
- static_cast<uint32>(timestamp - prev_timestamp) < 0x80000000;
-}
-
inline bool IsOlderFrameId(uint32 frame_id, uint32 prev_frame_id) {
return (frame_id == prev_frame_id) || IsNewerFrameId(prev_frame_id, frame_id);
}
@@ -38,16 +33,6 @@ inline bool IsNewerSequenceNumber(uint16 sequence_number,
return IsNewerPacketId(sequence_number, prev_sequence_number);
}
-inline base::TimeDelta RtpDeltaToTimeDelta(int64 rtp_delta, int rtp_timebase) {
- DCHECK_GT(rtp_timebase, 0);
- return rtp_delta * base::TimeDelta::FromSeconds(1) / rtp_timebase;
-}
-
-inline int64 TimeDeltaToRtpDelta(base::TimeDelta delta, int rtp_timebase) {
- DCHECK_GT(rtp_timebase, 0);
- return delta * rtp_timebase / base::TimeDelta::FromSeconds(1);
-}
-
} // namespace cast
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698