Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4091)

Unified Diff: chrome/browser/media/cast_transport_host_filter_unittest.cc

Issue 1515433002: Replace uses of raw uint32's with a type-checked RtpTimeTicks data type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed mkwst's comments, plus REBASE. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/cast_transport_host_filter_unittest.cc
diff --git a/chrome/browser/media/cast_transport_host_filter_unittest.cc b/chrome/browser/media/cast_transport_host_filter_unittest.cc
index 27aa970fd8a85fa88e5a92b585b0f124aaf2ab3c..fdb0fe6c95611a91fa95db189d9420ccb1c3f97f 100644
--- a/chrome/browser/media/cast_transport_host_filter_unittest.cc
+++ b/chrome/browser/media/cast_transport_host_filter_unittest.cc
@@ -106,8 +106,9 @@ TEST_F(CastTransportHostFilterTest, SimpleMessages) {
audio_frame.dependency = media::cast::EncodedFrame::KEY;
audio_frame.frame_id = 1;
audio_frame.referenced_frame_id = 1;
- audio_frame.rtp_timestamp = 47;
const int kSamples = 47;
+ audio_frame.rtp_timestamp =
+ media::cast::RtpTimeTicks() + media::cast::RtpTimeDelta::FromTicks(47);
apacible 2015/12/11 23:54:59 Is the 47 here related to kSamples?
miu 2015/12/12 00:23:30 Yes, good catch. Fixed.
const int kBytesPerSample = 2;
const int kChannels = 2;
audio_frame.data = std::string(kSamples * kBytesPerSample * kChannels, 'q');
@@ -126,7 +127,8 @@ TEST_F(CastTransportHostFilterTest, SimpleMessages) {
FakeSend(insert_video_frame);
CastHostMsg_SendSenderReport rtcp_msg(
- kChannelId, 1, base::TimeTicks(), 2);
+ kChannelId, 1, base::TimeTicks(),
+ media::cast::RtpTimeTicks().Expand(UINT32_C(2)));
FakeSend(rtcp_msg);
std::vector<uint32> frame_ids;

Powered by Google App Engine
This is Rietveld 408576698