Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2252)

Unified Diff: chrome/common/cast_messages.h

Issue 1515433002: Replace uses of raw uint32's with a type-checked RtpTimeTicks data type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed mkwst's comments, plus REBASE. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/cast_messages.h
diff --git a/chrome/common/cast_messages.h b/chrome/common/cast_messages.h
index e10717189ffb17db6e5995c88eaab3e9ced5e578..1b495a3c91dc4e4a126163edd79293f50bd2a8a2 100644
--- a/chrome/common/cast_messages.h
+++ b/chrome/common/cast_messages.h
@@ -3,15 +3,34 @@
// found in the LICENSE file.
// IPC messages for the Cast transport API.
-// Multiply-included message file, hence no include guard.
#include "ipc/ipc_message_macros.h"
#include "media/cast/cast_sender.h"
+#include "media/cast/common/rtp_time.h"
#include "media/cast/logging/logging_defines.h"
#include "media/cast/net/cast_transport_sender.h"
#include "media/cast/net/rtcp/rtcp_defines.h"
#include "net/base/ip_endpoint.h"
+#ifndef CHROME_COMMON_CAST_MESSAGES_H_
+#define CHROME_COMMON_CAST_MESSAGES_H_
+
+namespace IPC {
+
+template<>
+struct ParamTraits<media::cast::RtpTimeTicks> {
+ using param_type = media::cast::RtpTimeTicks;
+ static void Write(Message* m, const param_type& p);
+ static bool Read(const Message* m, base::PickleIterator* iter, param_type* r);
+ static void Log(const param_type& p, std::string* l);
+};
+
+} // namespace IPC
+
+#endif // CHROME_COMMON_CAST_MESSAGES_H_
+
+// Multiply-included message file, hence no include guard from here.
+
#undef IPC_MESSAGE_EXPORT
#define IPC_MESSAGE_EXPORT
#define IPC_MESSAGE_START CastMsgStart
@@ -161,7 +180,7 @@ IPC_MESSAGE_CONTROL4(
int32 /* channel_id */,
uint32 /* ssrc */,
base::TimeTicks /* current_time */,
- uint32 /* current_time_as_rtp_timestamp */)
+ media::cast::RtpTimeTicks /* current_time_as_rtp_timestamp */)
IPC_MESSAGE_CONTROL3(
CastHostMsg_CancelSendingFrames,

Powered by Google App Engine
This is Rietveld 408576698