Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 1515343002: New Mojom Parser: Validate the use of '&' and '?' (Closed)

Created:
5 years ago by rudominer
Modified:
5 years ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

New Mojom Parser: Validate the use of '&' and '?' The parser was not validating that after a user-defined type reference is resolved, that if the reference used a '&' or a '?' (or both) that the reference had resolved to a type for which this makes sense. This patch implements that. BUG=#461 R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8272d684e454a8572328feccda9f48a8d9ca3d87

Patch Set 1 : Revert accidental commit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
M mojom/mojom_parser/mojom/types.go View 1 chunk +15 lines, -0 lines 0 comments Download
M mojom/mojom_parser/parser/resolution_test.go View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
rudominer
Hi Alex, ptal.
5 years ago (2015-12-11 22:51:31 UTC) #4
azani
lgtm
5 years ago (2015-12-11 22:52:48 UTC) #5
rudominer
5 years ago (2015-12-11 22:56:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
8272d684e454a8572328feccda9f48a8d9ca3d87 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698