New Mojom Parser: Validate the use of '&' and '?'

mojom/mojom_parser/parser/resolution_test.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package parser
 
 import (
         "fmt"
         "mojom/mojom_parser/mojom"
         "strings"
@@ skipping 809 matching lines @@
         };
 
     const Hats MY_HAT = 1;
         `
                 test.addTestCase(contents, []string{
                         "Illegal assignment",
                         "Const MY_HAT of type Hats may not be assigned the value 1 of type int8."})
         }
 
         ////////////////////////////////////////////////////////////
+        // Group 3: Invalid use of interface request.
+        ////////////////////////////////////////////////////////////
+
+        ////////////////////////////////////////////////////////////
+        // Test Case: Make an interface request out of a struct
+        ////////////////////////////////////////////////////////////
+        {
+                contents := `
+        struct Foo{
+        };
+
+    struct Bar{
+        Foo& x;
+        };
+        `
+                test.addTestCase(contents, []string{
+                        "Invalid interface request specification",
+                        "Foo&. Foo is not an interface type"})
+        }
+
+        ////////////////////////////////////////////////////////////
+        // Test Case: Make a nullable interface request out of a struct
+        ////////////////////////////////////////////////////////////
+        {
+                contents := `
+        struct Foo{
+        };
+
+    struct Bar{
+        Foo&? x;
+        };
+        `
+                test.addTestCase(contents, []string{
+                        "Invalid interface request specification",
+                        "Foo&?. Foo is not an interface type"})
+        }
+
+        ////////////////////////////////////////////////////////////
+        // Group 4: Invalid use of nullable
+        ////////////////////////////////////////////////////////////
+
+        ////////////////////////////////////////////////////////////
+        // Test Case: Make nullable enum.
+        ////////////////////////////////////////////////////////////
+        {
+                contents := `
+        enum Hats {
+                COWBOY,
+                TOP
+        };
+
+    struct Bar{
+        Hats? my_hat;
+        };
+        `
+                test.addTestCase(contents, []string{
+                        "The type Hats? is invalid because Hats is an enum type and these may not be made nullable."})
+        }
+
+        ////////////////////////////////////////////////////////////
         // Execute all of the test cases.
         ////////////////////////////////////////////////////////////
         for i, c := range test.cases {
                 // Parse and resolve the mojom input.
                 descriptor := mojom.NewMojomDescriptor()
                 parser := MakeParser(c.fileName, c.mojomContents, descriptor, c.importedFrom)
                 parser.Parse()
                 if !parser.OK() {
                         t.Errorf("Parsing error for %s: %s", c.fileName, parser.GetError().Error())
                         continue
                 }
                 err := descriptor.Resolve()
                 if err == nil {
                         t.Errorf("Resolution unexpectedly succeeded for test case %d.", i)
                         continue
                 }
                 got := err.Error()
                 for _, expected := range c.expectedErrors {
                         if !strings.Contains(got, expected) {
                                 t.Errorf("%s:\n*****expected to contain:\n%s\n****actual\n%s", c.fileName, expected, got)
                         }
                 }
 
         }
 }