Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc

Issue 1515293003: Fix invalid cast in AutofillDialogControllerTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_dialog_controller_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
index 3b0f010ffb8522e177ec71cabfc88f2e901bc7ba..71269169ddbaae9a13d509640faae103710bc213 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
@@ -523,7 +523,7 @@ IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest, Submit) {
AddAutofillProfileToProfile(controller()->profile(),
test::GetVerifiedProfile());
scoped_ptr<AutofillDialogViewTester> view = AutofillDialogViewTester::For(
- static_cast<TestAutofillDialogController*>(controller())->view());
+ static_cast<AutofillDialogControllerImpl*>(controller())->view());
Evan Stade 2015/12/11 23:17:40 you can just remove this cast
krasin 2015/12/11 23:23:50 Done.
view->SetTextContentsOfSuggestionInput(SECTION_CC, ASCIIToUTF16("123"));
GetViewTester()->SubmitForTesting();
RunMessageLoop();
@@ -887,7 +887,7 @@ IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest, AutocompleteEvent) {
scoped_ptr<AutofillDialogViewTester> view =
AutofillDialogViewTester::For(
- static_cast<TestAutofillDialogController*>(controller)->view());
+ static_cast<AutofillDialogControllerImpl*>(controller)->view());
Evan Stade 2015/12/11 23:17:40 you don't need this cast
krasin 2015/12/11 23:23:50 Done.
view->SetTextContentsOfSuggestionInput(SECTION_CC, ASCIIToUTF16("123"));
view->SubmitForTesting();
ExpectDomMessage("success");
@@ -909,7 +909,7 @@ IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest,
scoped_ptr<AutofillDialogViewTester> view =
AutofillDialogViewTester::For(
- static_cast<TestAutofillDialogController*>(controller)->view());
+ static_cast<AutofillDialogControllerImpl*>(controller)->view());
Evan Stade 2015/12/11 23:17:40 ditto
krasin 2015/12/11 23:23:50 Done.
view->SetTextContentsOfSuggestionInput(SECTION_CC, ASCIIToUTF16("123"));
view->SubmitForTesting();
ExpectDomMessage("error: invalid");
@@ -933,7 +933,7 @@ IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest,
SetUpHtmlAndInvoke("<input autocomplete='cc-name'>");
ASSERT_TRUE(controller);
AutofillDialogViewTester::For(
- static_cast<TestAutofillDialogController*>(controller)->view())->
+ static_cast<AutofillDialogControllerImpl*>(controller)->view())->
CancelForTesting();
ExpectDomMessage("error: cancel");
}
@@ -957,7 +957,7 @@ IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest,
ExpectDomMessage("iframe loaded");
AutofillDialogViewTester::For(
- static_cast<TestAutofillDialogController*>(controller)->view())->
+ static_cast<AutofillDialogControllerImpl*>(controller)->view())->
CancelForTesting();
ExpectDomMessage("error: cancel");
}
@@ -986,7 +986,7 @@ IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest,
scoped_ptr<AutofillDialogViewTester> view =
AutofillDialogViewTester::For(
- static_cast<TestAutofillDialogController*>(controller)->view());
+ static_cast<AutofillDialogControllerImpl*>(controller)->view());
view->SetTextContentsOfSuggestionInput(SECTION_CC, ASCIIToUTF16("123"));
view->SubmitForTesting();
ExpectDomMessage("success");
« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_dialog_controller_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698