Fix invalid cast in AutofillDialogControllerTest.

chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 505 matching lines @@
 };
 
 // Submit the form data.
 IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest, Submit) {
   base::HistogramTester histogram;
   AddCreditcardToProfile(controller()->profile(),
                          test::GetVerifiedCreditCard());
   AddAutofillProfileToProfile(controller()->profile(),
                               test::GetVerifiedProfile());
   scoped_ptr<AutofillDialogViewTester> view = AutofillDialogViewTester::For(
-      static_cast<TestAutofillDialogController*>(controller())->view());
+      static_cast<AutofillDialogControllerImpl*>(controller())->view());

[Evan Stade, 2015/12/11 23:17:40]

you can just remove this cast

[krasin, 2015/12/11 23:23:50]

Done.

   view->SetTextContentsOfSuggestionInput(SECTION_CC, ASCIIToUTF16("123"));
   GetViewTester()->SubmitForTesting();
   RunMessageLoop();
 
   histogram.ExpectTotalCount("RequestAutocomplete.UiDuration.Submit", 1);
   histogram.ExpectTotalCount("RequestAutocomplete.UiDuration.Cancel", 0);
 }
 
 // Cancel out of the dialog.
 IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest, Cancel) {
@@ skipping 343 matching lines @@
   AutofillDialogControllerImpl* controller =
       SetUpHtmlAndInvoke("<input autocomplete='cc-name'>");
   ASSERT_TRUE(controller);
 
   AddCreditcardToProfile(controller->profile(), test::GetVerifiedCreditCard());
   AddAutofillProfileToProfile(controller->profile(),
                               test::GetVerifiedProfile());
 
   scoped_ptr<AutofillDialogViewTester> view =
       AutofillDialogViewTester::For(
-          static_cast<TestAutofillDialogController*>(controller)->view());
+          static_cast<AutofillDialogControllerImpl*>(controller)->view());

[Evan Stade, 2015/12/11 23:17:40]

you don't need this cast

[krasin, 2015/12/11 23:23:50]

Done.

   view->SetTextContentsOfSuggestionInput(SECTION_CC, ASCIIToUTF16("123"));
   view->SubmitForTesting();
   ExpectDomMessage("success");
 }
 
 IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest,
                        AutocompleteErrorEventReasonInvalid) {
   AutofillDialogControllerImpl* controller =
       SetUpHtmlAndInvoke("<input autocomplete='cc-name' pattern='.*zebra.*'>");
   ASSERT_TRUE(controller);
 
   const CreditCard& credit_card = test::GetVerifiedCreditCard();
   ASSERT_TRUE(
       credit_card.GetRawInfo(CREDIT_CARD_NAME).find(ASCIIToUTF16("zebra")) ==
           base::string16::npos);
   AddCreditcardToProfile(controller->profile(), credit_card);
   AddAutofillProfileToProfile(controller->profile(),
                               test::GetVerifiedProfile());
 
   scoped_ptr<AutofillDialogViewTester> view =
       AutofillDialogViewTester::For(
-          static_cast<TestAutofillDialogController*>(controller)->view());
+          static_cast<AutofillDialogControllerImpl*>(controller)->view());

[Evan Stade, 2015/12/11 23:17:40]

ditto

[krasin, 2015/12/11 23:23:50]

Done.

   view->SetTextContentsOfSuggestionInput(SECTION_CC, ASCIIToUTF16("123"));
   view->SubmitForTesting();
   ExpectDomMessage("error: invalid");
 
   int invalid_count = -1;
   ASSERT_TRUE(content::ExecuteScriptAndExtractInt(
       GetRenderViewHost(), "send(invalidEvents.length);", &invalid_count));
   EXPECT_EQ(1, invalid_count);
 
   std::string invalid_type;
   ASSERT_TRUE(content::ExecuteScriptAndExtractString(
       GetRenderViewHost(),
       "send(invalidEvents[0].target.autocomplete);",
       &invalid_type));
   EXPECT_EQ("cc-name", invalid_type);
 }
 
 IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest,
                        AutocompleteErrorEventReasonCancel) {
   AutofillDialogControllerImpl* controller =
       SetUpHtmlAndInvoke("<input autocomplete='cc-name'>");
   ASSERT_TRUE(controller);
   AutofillDialogViewTester::For(
-      static_cast<TestAutofillDialogController*>(controller)->view())->
+      static_cast<AutofillDialogControllerImpl*>(controller)->view())->
           CancelForTesting();
   ExpectDomMessage("error: cancel");
 }
 
 // http://crbug.com/318526
 #if defined(OS_MACOSX)
 #define MAYBE_ErrorWithFrameNavigation DISABLED_ErrorWithFrameNavigation
 #else
 #define MAYBE_ErrorWithFrameNavigation ErrorWithFrameNavigation
 #endif
 IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest,
                        MAYBE_ErrorWithFrameNavigation) {
   AutofillDialogControllerImpl* controller =
       SetUpHtmlAndInvoke("<input autocomplete='cc-name'>");
   ASSERT_TRUE(controller);
 
   std::string unused;
   ASSERT_TRUE(content::ExecuteScriptAndExtractString(GetRenderViewHost(),
                                                      "loadIframe();",
                                                      &unused));
   ExpectDomMessage("iframe loaded");
 
   AutofillDialogViewTester::For(
-      static_cast<TestAutofillDialogController*>(controller)->view())->
+      static_cast<AutofillDialogControllerImpl*>(controller)->view())->
           CancelForTesting();
   ExpectDomMessage("error: cancel");
 }
 
 IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest, NoCvcSegfault) {
   controller()->set_use_validation(true);
 
   CreditCard credit_card(test::GetVerifiedCreditCard());
   controller()->GetTestingManager()->AddTestingCreditCard(&credit_card);
   EXPECT_FALSE(controller()->IsEditingExistingData(SECTION_CC));
 
   ASSERT_NO_FATAL_FAILURE(GetViewTester()->SubmitForTesting());
 }
 
 // Verify that filling a form works correctly, including filling the CVC when
 // that is requested separately.
 IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest,
                        FillFormIncludesCVC) {
   AutofillDialogControllerImpl* controller =
       SetUpHtmlAndInvoke("<input autocomplete='cc-csc'>");
   ASSERT_TRUE(controller);
 
   AddCreditcardToProfile(controller->profile(), test::GetVerifiedCreditCard());
   AddAutofillProfileToProfile(controller->profile(),
                               test::GetVerifiedProfile());
 
   scoped_ptr<AutofillDialogViewTester> view =
       AutofillDialogViewTester::For(
-          static_cast<TestAutofillDialogController*>(controller)->view());
+          static_cast<AutofillDialogControllerImpl*>(controller)->view());
   view->SetTextContentsOfSuggestionInput(SECTION_CC, ASCIIToUTF16("123"));
   view->SubmitForTesting();
   ExpectDomMessage("success");
   EXPECT_EQ("123", GetValueForHTMLFieldOfType("cc-csc"));
 }
 
 IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest, AddNewClearsComboboxes) {
   // Ensure the input under test is a combobox.
   ASSERT_TRUE(
       controller()->ComboboxModelForAutofillType(CREDIT_CARD_EXP_MONTH));
@@ skipping 330 matching lines @@
   ASSERT_TRUE(content::ExecuteScriptAndExtractString(GetRenderViewHost(),
                                                      "navigateFrame();",
                                                      &unused));
   ExpectDomMessage("iframe loaded");
   ChromeAutofillClient* client =
       ChromeAutofillClient::FromWebContents(GetActiveWebContents());
   EXPECT_FALSE(client->GetDialogControllerForTesting());
 }
 
 }  // namespace autofill