Fix invalid cast in AutofillDialogControllerTest.

Fix invalid cast in AutofillDialogControllerTest.

An instance of autofill::AutofillDialogControllerImpl was converted
to its base class, TestAutofillDialogController to bypass protected
modifier on view(). This invalid case was found by CFI check:

https://www.chromium.org/developers/testing/control-flow-integrity

BUG=569102
Committed: https://crrev.com/26049f31cc0fcd73bfaa9b0bc4e4493b32951e79
Cr-Commit-Position: refs/heads/master@{#364872}

[krasin, 2015-12-11 22:22:57]

krasin@google.com changed reviewers:
+ estade@chromium.org

[krasin, 2015-12-11 22:45:00]

krasin@google.com changed reviewers:
+ isherman@chromium.org

[Evan Stade, 2015-12-11 23:17:40]

https://codereview.chromium.org/1515293003/diff/1/chrome/browser/ui/autofill/...
File chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
(right):

https://codereview.chromium.org/1515293003/diff/1/chrome/browser/ui/autofill/...
chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:526:
static_cast<AutofillDialogControllerImpl*>(controller())->view());
you can just remove this cast

https://codereview.chromium.org/1515293003/diff/1/chrome/browser/ui/autofill/...
chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:890:
static_cast<AutofillDialogControllerImpl*>(controller)->view());
you don't need this cast

https://codereview.chromium.org/1515293003/diff/1/chrome/browser/ui/autofill/...
chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:912:
static_cast<AutofillDialogControllerImpl*>(controller)->view());
ditto

[krasin, 2015-12-11 23:23:50]

Done. Very nice catch again, thx!

https://codereview.chromium.org/1515293003/diff/1/chrome/browser/ui/autofill/...
File chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
(right):

https://codereview.chromium.org/1515293003/diff/1/chrome/browser/ui/autofill/...
chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:526:
static_cast<AutofillDialogControllerImpl*>(controller())->view());
On 2015/12/11 23:17:40, Evan Stade wrote:
> you can just remove this cast

Done.

https://codereview.chromium.org/1515293003/diff/1/chrome/browser/ui/autofill/...
chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:890:
static_cast<AutofillDialogControllerImpl*>(controller)->view());
On 2015/12/11 23:17:40, Evan Stade wrote:
> you don't need this cast

Done.

https://codereview.chromium.org/1515293003/diff/1/chrome/browser/ui/autofill/...
chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:912:
static_cast<AutofillDialogControllerImpl*>(controller)->view());
On 2015/12/11 23:17:40, Evan Stade wrote:
> ditto

Done.

[Evan Stade, 2015-12-11 23:26:49]

lgtm

[krasin, 2015-12-11 23:27:55]

The CQ bit was checked by krasin@google.com

[commit-bot: I haz the power, 2015-12-11 23:29:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1515293003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1515293003/20001

[commit-bot: I haz the power, 2015-12-12 00:55:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-12 00:55:05]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[krasin, 2015-12-12 00:58:22]

The CQ bit was checked by krasin@google.com

[commit-bot: I haz the power, 2015-12-12 00:58:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1515293003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1515293003/20001

[commit-bot: I haz the power, 2015-12-12 02:23:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-12 02:25:22]

Description was changed from

==========
Fix invalid cast in AutofillDialogControllerTest.

An instance of autofill::AutofillDialogControllerImpl was converted
to its base class, TestAutofillDialogController to bypass protected
modifier on view(). This invalid case was found by CFI check:

https://www.chromium.org/developers/testing/control-flow-integrity

BUG=569102
==========

to

==========
Fix invalid cast in AutofillDialogControllerTest.

An instance of autofill::AutofillDialogControllerImpl was converted
to its base class, TestAutofillDialogController to bypass protected
modifier on view(). This invalid case was found by CFI check:

https://www.chromium.org/developers/testing/control-flow-integrity

BUG=569102

Committed: https://crrev.com/26049f31cc0fcd73bfaa9b0bc4e4493b32951e79
Cr-Commit-Position: refs/heads/master@{#364872}
==========

[commit-bot: I haz the power, 2015-12-12 02:25:23]

Patchset 2 (id:??) landed as
https://crrev.com/26049f31cc0fcd73bfaa9b0bc4e4493b32951e79
Cr-Commit-Position: refs/heads/master@{#364872}