Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1515123002: GN: Use gold linker for arm64 (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@arm64-android
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Use gold linker for arm64 GN doesn't currently support adding an .a entry to libs (it won't not prefix it with -l). Easiest fix is to switch to gold linker, which supports using -l/path.a BUG=568883

Patch Set 1 #

Patch Set 2 : just use gold #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/android/BUILD.gn View 1 2 chunks +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
agrieve
On 2015/12/11 13:21:32, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org ◐ o ◑
5 years ago (2015-12-11 13:21:37 UTC) #3
agrieve
On 2015/12/11 13:21:37, agrieve wrote: > On 2015/12/11 13:21:32, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
5 years ago (2015-12-11 14:59:06 UTC) #4
agrieve
On 2015/12/11 14:59:06, agrieve wrote: > On 2015/12/11 13:21:37, agrieve wrote: > > On 2015/12/11 ...
5 years ago (2015-12-11 16:22:57 UTC) #6
Yaron
does gyp use gold for arm64?
5 years ago (2015-12-11 16:24:58 UTC) #7
agrieve
On 2015/12/11 16:24:58, Yaron wrote: > does gyp use gold for arm64? pasko pointed out ...
5 years ago (2015-12-11 17:26:06 UTC) #8
agrieve
5 years ago (2015-12-11 17:51:57 UTC) #9
On 2015/12/11 17:26:06, agrieve wrote:
> On 2015/12/11 16:24:58, Yaron wrote:
> > does gyp use gold for arm64?
> 
> pasko pointed out that we shouldn't switch yet due to some arm errata. :/

Spoke with torne@ about this and looks like the answer is that I'll need to
teach GN how to pass libs without -l

Powered by Google App Engine
This is Rietveld 408576698