Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1514373002: Fix gn gen failure in build/config/android/BUILD.gn for arm64 (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn gen failure in build/config/android/BUILD.gn for arm64 BUG=568883 Committed: https://crrev.com/6f0958f7d8e4700226b67399bcfaddc464dd737b Cr-Commit-Position: refs/heads/master@{#364711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/config/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
agrieve
On 2015/12/11 11:24:03, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org ◐ o ◑
5 years ago (2015-12-11 11:24:23 UTC) #3
Yaron
lgtm - seems like a hack tho
5 years ago (2015-12-11 15:00:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514373002/1
5 years ago (2015-12-11 15:33:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 16:18:43 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-11 16:19:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f0958f7d8e4700226b67399bcfaddc464dd737b
Cr-Commit-Position: refs/heads/master@{#364711}

Powered by Google App Engine
This is Rietveld 408576698