Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1514873003: Remove flag needed by outdated libpng (Closed)

Created:
5 years ago by msarett
Modified:
5 years ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove flag needed by outdated libpng BUG=skia: Committed: https://skia.googlesource.com/skia/+/7d2e2fadbd327dd93359c29d6b536e6f88d9b47d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M gyp/images.gyp View 1 chunk +0 lines, -7 lines 0 comments Download

Depends on Patchset:

Issue 1188223002 Patch 60001

Messages

Total messages: 7 (3 generated)
msarett
This has been annoying me because clang doesn't recognize this flag (so it makes clang ...
5 years ago (2015-12-10 22:28:32 UTC) #2
scroggo
lgtm
5 years ago (2015-12-10 22:32:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514873003/1
5 years ago (2015-12-10 22:32:49 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-10 22:45:06 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7d2e2fadbd327dd93359c29d6b536e6f88d9b47d

Powered by Google App Engine
This is Rietveld 408576698