Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1512243003: [turbofan] Remove FP-based AccessBuilder functions. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-access-builder-name
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove FP-based AccessBuilder functions. This is deprecating the ability of TurboFan to access FP-based slots via LoadField and StoreField nodes. The corresponding constructors for FieldAccess tuples are being removed. R=bmeurer@chromium.org Committed: https://crrev.com/aa4a1abdcfca1ef7048e68006c2c20d086097462 Cr-Commit-Position: refs/heads/master@{#32760}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M src/compiler/access-builder.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/access-builder.cc View 1 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
5 years ago (2015-12-10 14:21:34 UTC) #1
Benedikt Meurer
lgtm
5 years ago (2015-12-10 15:12:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512243003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512243003/20001
5 years ago (2015-12-10 15:13:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 15:52:16 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-10 15:53:08 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa4a1abdcfca1ef7048e68006c2c20d086097462
Cr-Commit-Position: refs/heads/master@{#32760}

Powered by Google App Engine
This is Rietveld 408576698