Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1514853002: Remove --disable-svg1dom runtime flag (Closed)

Created:
5 years ago by davve
Modified:
5 years ago
Reviewers:
philipj_slow, jam, fs
CC:
chromium-reviews, Eric Willigers, krit, creis+watch_chromium.org, darktears, blink-reviews-animation_chromium.org, nasko+codewatch_chromium.org, jam, kouhei+svg_chromium.org, dglazkov+blink, shans, darin-cc_chromium.org, rjwright, gyuyoung2, blink-reviews, f(malita), Stephen Chennney, rwlbuis, blink-reviews-api_chromium.org, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove --disable-svg1dom runtime flag Because the SVG1DOM UseCounter was high enough that we couldn't rip all of it out together[1] we might as well drop the run-time flag for disabling it. It carries a non-significant cost of generated bindings code (~700 lines less and simpler code) and won't be of much use now anyway. [1] https://code.google.com/p/chromium/issues/detail?id=415074#c4 BUG=415074 Committed: https://crrev.com/1b500ff46b2d534283ace2c414dfceeec2729596 Cr-Commit-Position: refs/heads/master@{#364657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -314 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedAngle.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedBoolean.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedEnumeration.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedInteger.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedLength.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedLengthList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedNumber.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedNumberList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedPreserveAspectRatio.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedRect.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedString.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedTransformList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGCircleElement.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGClipPathElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGComponentTransferFunctionElement.idl View 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGCursorElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGEllipseElement.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEBlendElement.idl View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEColorMatrixElement.idl View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEComponentTransferElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFECompositeElement.idl View 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.idl View 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.idl View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDistantLightElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEGaussianBlurElement.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEImageElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMergeNodeElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMorphologyElement.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEOffsetElement.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEPointLightElement.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFESpotLightElement.idl View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFETileElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFETurbulenceElement.idl View 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterElement.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFitToViewBox.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGForeignObjectElement.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGradientElement.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLength.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLineElement.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLinearGradientElement.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMarkerElement.idl View 1 chunk +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMaskElement.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPatternElement.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPointList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPolygonElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPolylineElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPreserveAspectRatio.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRadialGradientElement.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRectElement.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.idl View 3 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStopElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStringList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTests.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextContentElement.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextPathElement.idl View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextPositioningElement.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransform.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGURIReference.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUnitTypes.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGZoomAndPan.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
davve
5 years ago (2015-12-10 13:42:40 UTC) #2
davve
+jam for content/
5 years ago (2015-12-10 13:44:09 UTC) #4
philipj_slow
third_party/WebKit/ LGTM
5 years ago (2015-12-10 13:54:08 UTC) #5
fs
On 2015/12/10 at 13:54:08, philipj wrote: > third_party/WebKit/ LGTM LGTM2
5 years ago (2015-12-10 14:26:38 UTC) #6
jam
lgtm
5 years ago (2015-12-10 20:22:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514853002/1
5 years ago (2015-12-11 07:52:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 10:28:03 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-11 10:29:09 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b500ff46b2d534283ace2c414dfceeec2729596
Cr-Commit-Position: refs/heads/master@{#364657}

Powered by Google App Engine
This is Rietveld 408576698