Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 1505953008: Split SVGSVGElement.create* functions from SVG1DOM counter (Closed)

Created:
5 years ago by davve
Modified:
5 years ago
Reviewers:
Ilya Sherman, fs
CC:
fs, asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-disable-svg1dom-runtime
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split SVGSVGElement.create* functions from SVG1DOM counter Measure them individually to see which ones, if any, has any usage. They are interesting in the sense of being the only way of creating such objects. BUG=415074 Committed: https://crrev.com/1edfb1a8dcce9c9081f772237c631a2ec6774b1f Cr-Commit-Position: refs/heads/master@{#364695}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.idl View 1 chunk +8 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
davve
PTAL
5 years ago (2015-12-10 14:49:58 UTC) #2
fs
third_party/WebKit/ LGTM
5 years ago (2015-12-10 14:52:23 UTC) #3
Ilya Sherman
metrics lgtm
5 years ago (2015-12-10 16:22:12 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1514853002 Patch 1). Please resolve the dependency and ...
5 years ago (2015-12-10 16:23:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505953008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505953008/20001
5 years ago (2015-12-11 11:09:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-11 14:07:54 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-11 14:09:02 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1edfb1a8dcce9c9081f772237c631a2ec6774b1f
Cr-Commit-Position: refs/heads/master@{#364695}

Powered by Google App Engine
This is Rietveld 408576698