chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java - Issue 1514833002: [Offline Pages on the NTP] Bypass the network interstitial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 1514833002: [Offline Pages on the NTP] Bypass the network interstitial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offline_badge

Patch Set: getOfflineUrlForOnlineUrl returns emtpy string, not null Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

index 881bf0ab94ed9bd89298d2247b5727458841b567..6e6fe3554457f6fc535581d52cab0ede382ddb88 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

@@ -337,7 +337,7 @@ public final class OfflinePageBridge {

/**

* Gets the offline URL of an offline page of that is saved for the online URL.

* @param onlineUrl Online URL, which might have offline copy.

- * @return URL pointing to the offline copy or <code>null</code> if none exists.

+ * @return URL pointing to the offline copy or the empty string if none exists.

fgorski 2016/01/08 17:37:51 Thanks for catching that. I think this should actu

Marc Treib 2016/01/11 10:32:23 Done.

@VisibleForTesting

public String getOfflineUrlForOnlineUrl(String onlineUrl) {