[Offline Pages on the NTP] Bypass the network interstitial

chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.offlinepages;
 
 import android.os.AsyncTask;
 
 import org.chromium.base.ObserverList;
 import org.chromium.base.ThreadUtils;
@@ skipping 319 matching lines @@
     /**
      * Starts a check of offline page metadata, e.g. are all offline copies present.
      */
     public void checkOfflinePageMetadata() {
         nativeCheckMetadataConsistency(mNativeOfflinePageBridge);
     }
 
     /**
      * Gets the offline URL of an offline page of that is saved for the online URL.
      * @param onlineUrl Online URL, which might have offline copy.
-     * @return URL pointing to the offline copy or <code>null</code> if none exists.
+     * @return URL pointing to the offline copy or the empty string if none exists.

[fgorski, 2016/01/08 17:37:51]

Thanks for catching that. I think this should actually be null. I'll consult
with clank people.

Perhaps you should fix it below in code (replace empty with null). And I can
overhaul everything once I get a response.

[Marc Treib, 2016/01/11 10:32:23]

Done.

      */
     @VisibleForTesting
     public String getOfflineUrlForOnlineUrl(String onlineUrl) {
         assert mIsNativeOfflinePageModelLoaded;
         return nativeGetOfflineUrlForOnlineUrl(mNativeOfflinePageBridge, onlineUrl);
     }
 
     /**
      * Returns <code>true</code> if offline URL points to a local copy of an offline page.
      * @param offlineUrl A URL potentially pointing to an offline copy of an offline page.
@@ skipping 80 matching lines @@
             DeletePageCallback callback, long bookmarkId);
     private native void nativeDeletePages(
             long nativeOfflinePageBridge, DeletePageCallback callback, long[] bookmarkIds);
     private native void nativeGetPagesToCleanUp(
             long nativeOfflinePageBridge, List<OfflinePageItem> offlinePages);
     private native void nativeCheckMetadataConsistency(long nativeOfflinePageBridge);
     private native String nativeGetOfflineUrlForOnlineUrl(
             long nativeOfflinePageBridge, String onlineUrl);
     private native boolean nativeIsOfflinePageUrl(long nativeOfflinePageBridge, String offlineUrl);
 }