chrome/browser/android/offline_pages/offline_page_bridge.cc - Issue 1514833002: [Offline Pages on the NTP] Bypass the network interstitial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 1514833002: [Offline Pages on the NTP] Bypass the network interstitial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offline_badge

Patch Set: review/rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/offline_pages/offline_page_bridge.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc

index 45d7f067b85a079c4280174da7afbc10f31d77da..6101adc162b61ac0590dd8f1a0272c4ae3e6a77d 100644

--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc

+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc

@@ -234,6 +234,8 @@ ScopedJavaLocalRef<jstring> OfflinePageBridge::GetOfflineUrlForOnlineUrl(

GURL online_url(ConvertJavaStringToUTF8(env, j_online_url));

GURL offline_url =

OfflinePageUtils::GetOfflineURLForOnlineURL(browser_context_, online_url);

+ if (!offline_url.is_valid())

+ return ScopedJavaLocalRef<jstring>();

return ConvertUTF8ToJavaString(env, offline_url.spec());

}

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | no next file » | no next file with comments »