Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3399)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 1514833002: [Offline Pages on the NTP] Bypass the network interstitial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offline_badge
Patch Set: review/rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 0c27b1ffed2d557564a853633950c41695780b80..f17868f4165e5c82a20bfc535625866531d372b3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -48,6 +48,7 @@ import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
import org.chromium.chrome.browser.ntp.interests.InterestsPage;
import org.chromium.chrome.browser.ntp.interests.InterestsPage.InterestsClickListener;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
+import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
import org.chromium.chrome.browser.preferences.DocumentModeManager;
import org.chromium.chrome.browser.preferences.DocumentModePreference;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
@@ -336,6 +337,14 @@ public class NewTabPage
@Override
public void open(String url) {
+ if (mIsDestroyed) return;
+ if (isNtpOfflinePagesEnabled()) {
+ if (mOfflinePageBridge == null) {
+ mOfflinePageBridge = new OfflinePageBridge(mProfile);
+ }
+ url = OfflinePageUtils.getLaunchUrlFromOnlineUrl(
+ mNewTabPageView.getContext(), mOfflinePageBridge, url);
+ }
mTab.loadUrl(new LoadUrlParams(url, PageTransition.AUTO_BOOKMARK));
}
@@ -460,7 +469,7 @@ public class NewTabPage
if (mIsDestroyed || !isNtpOfflinePagesEnabled()) return false;
if (isLocalUrl(pageUrl)) return true;
if (mOfflinePageBridge == null) mOfflinePageBridge = new OfflinePageBridge(mProfile);
- return mOfflinePageBridge.getPageByOnlineURL(pageUrl) != null;
+ return mOfflinePageBridge.getOfflineUrlForOnlineUrl(pageUrl) != null;
}
@Override
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698