Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: mojo/public/c/system/BUILD.gn

Issue 1514763002: Remove the //mojo/public/c/system:for_component target. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/c/system/BUILD.gn
diff --git a/mojo/public/c/system/BUILD.gn b/mojo/public/c/system/BUILD.gn
index 2e45b941db1158292e0df46608e5f9cd91bd6b0e..197d4948a5e269d9538e621f5c8df543d27bd236 100644
--- a/mojo/public/c/system/BUILD.gn
+++ b/mojo/public/c/system/BUILD.gn
@@ -4,10 +4,9 @@
import("../../mojo_sdk.gni")
-# Depend on this target to use the types etc defined in the system without
-# linking against a specific implementation of the system. To link against a
-# particular implementation, use the :for_component or
-# :for_shared_library targets, depending on the type of target you are.
+# This target merely declares the Mojo system API's types, functions, etc. To
+# use the functions, you must also depend on a specific implementation (e.g.,
+# ../../platform/native:system).
mojo_sdk_source_set("system") {
sources = [
"buffer.h",
@@ -20,19 +19,7 @@ mojo_sdk_source_set("system") {
]
}
-# In an is_component_build build, everything can link against //mojo/edk/system
-# because it is built as a shared library. However, in a static build,
-# //mojo/edk/system is linked into an executable (e.g., mojo_shell), and must be
-# injected into other shared libraries (i.e., Mojo Apps) that need the mojo
-# system API.
-#
-# For component targets, add //mojo/public/c/system:for_component to your deps
-# section.
-#
-# For shared_library targets (e.g., a Mojo App), add
-# //mojo/public/c/system:for_shared_library to your deps
-
-# TODO(jamesr): Eliminate the need for these targets. crbug.com/438701
+# TODO(vtl): Remove this.
group("for_shared_library") {
public_deps = [
":system",
@@ -41,14 +28,3 @@ group("for_shared_library") {
"../../platform/native:system",
]
}
-
-group("for_component") {
- public_deps = [
- ":system",
- ]
- if (is_component_build) {
- deps = [
- "../../../edk/system",
- ]
- }
-}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698