Revert of Use a single views::MenuConfig instance for each platform

Revert of Use a single views::MenuConfig instance for each platform (patchset #7 id:140001 of https://codereview.chromium.org/1477253002/ )

Reason for revert:
This broke compilation on https://build.chromium.org/p/chromium.android/builders/Android%20Aura%20Builder%20%28dbg%29/builds/2497/steps/compile/logs/stdio (the patch landed in an earlier build, but was masked by another compile failure :-|):

../../ui/views/controls/menu/menu_config.cc:45: error: undefined reference to 'views::MenuConfig::Init()'

Original issue's description:
> Use a single views::MenuConfig instance for each platform
>
> Most noticeably, always use the GTK-style menu layout on Desktop Linux.
>
> Previously, the MenuConfig used by a particular MenuItemView could be
> affected by that View's Widget's GetNativeTheme().
>
> This once allowed a menu to decide whether to use a ChromeOS-style menu
> or a native Desktop-style menu config on the same platform. But that's
> no longer needed, and makes trouble with the "Classic Theme" in Desktop
> Linux. (e.g. because menus are not always in a Widget when they are
> configured, so the native theme is hard to determine.)
>
> Using a single instance simplifies things and fixes a regression where
> the Ash-style was being used on Desktop Linux, resulting in menus
> without a border and unexpectedly large item padding. Regression due to
> the combination of r344651, r345479, and r360168.
>
> Note this means --open-ash on Desktop Linux, and Metro mode on Windows,
> will use non-Ash menus. See screenshots at http://crbug.com/544550#c13
>
> BUG=415953, 544550
>
> Committed: https://crrev.com/5d23f8c18f1d9fbf1655ece40b31d59dea443c60
> Cr-Commit-Position: refs/heads/master@{#363924}

TBR=sky@chromium.org,estade@chromium.org,tapted@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=415953, 544550
Committed: https://crrev.com/2903ab2c274a0246c603b1b29d9967d3c9c8ff00
Cr-Commit-Position: refs/heads/master@{#364371}

[johnme, 2015-12-10 15:08:45]

Created Revert of Use a single views::MenuConfig instance for each platform

[commit-bot: I haz the power, 2015-12-10 15:09:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514693006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514693006/1

[commit-bot: I haz the power, 2015-12-10 15:10:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 15:10:48]

Failed to apply patch for ui/views/controls/menu/native_menu_win.cc:
While running git apply --index -3 -p1;
  error: patch failed: ui/views/controls/menu/native_menu_win.cc:271
  Falling back to three-way merge...
  Applied patch to 'ui/views/controls/menu/native_menu_win.cc' with conflicts.
  U ui/views/controls/menu/native_menu_win.cc

Patch:       ui/views/controls/menu/native_menu_win.cc
Index: ui/views/controls/menu/native_menu_win.cc
diff --git a/ui/views/controls/menu/native_menu_win.cc
b/ui/views/controls/menu/native_menu_win.cc
index
84c0fd950f11b9742719e3205a4f1896a34537bf..3c656f16c7c94c06f598c31801e79105674fca11
100644
--- a/ui/views/controls/menu/native_menu_win.cc
+++ b/ui/views/controls/menu/native_menu_win.cc
@@ -271,7 +271,8 @@
                  data->native_menu_win->model_->IsItemCheckedAt(
                      data->model_index)) {
         // Manually render a checkbox.
-        const MenuConfig& config = MenuConfig::instance();
+        ui::NativeThemeWin* native_theme = ui::NativeThemeWin::instance();
+        const MenuConfig& config = MenuConfig::instance(native_theme);
         NativeTheme::State state;
         if (draw_item_struct->itemState & ODS_DISABLED) {
           state = NativeTheme::kDisabled;
@@ -287,7 +288,6 @@
         gfx::Rect bounds(0, 0, config.check_width, config.check_height);
 
         // Draw the background and the check.
-        ui::NativeThemeWin* native_theme = ui::NativeThemeWin::instance();
         native_theme->Paint(
             canvas.sk_canvas(), NativeTheme::kMenuCheckBackground,
             state, bounds, extra);

[commit-bot: I haz the power, 2015-12-10 15:11:21]

The CQ bit was unchecked by commit-bot@chromium.org

[johnme, 2015-12-10 16:09:46]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2015-12-10 16:10:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514693006/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514693006/280001

[commit-bot: I haz the power, 2015-12-10 16:12:07]

Description was changed from

==========
Revert of Use a single views::MenuConfig instance for each platform (patchset #7
id:140001 of https://codereview.chromium.org/1477253002/ )

Reason for revert:
This broke compilation on
https://build.chromium.org/p/chromium.android/builders/Android%20Aura%20Build...
(the patch landed in an earlier build, but was masked by another compile failure
:-|):

../../ui/views/controls/menu/menu_config.cc:45: error: undefined reference to
'views::MenuConfig::Init()'

Original issue's description:
> Use a single views::MenuConfig instance for each platform
> 
> Most noticeably, always use the GTK-style menu layout on Desktop Linux.
> 
> Previously, the MenuConfig used by a particular MenuItemView could be
> affected by that View's Widget's GetNativeTheme().
> 
> This once allowed a menu to decide whether to use a ChromeOS-style menu
> or a native Desktop-style menu config on the same platform. But that's
> no longer needed, and makes trouble with the "Classic Theme" in Desktop
> Linux. (e.g. because menus are not always in a Widget when they are
> configured, so the native theme is hard to determine.)
> 
> Using a single instance simplifies things and fixes a regression where
> the Ash-style was being used on Desktop Linux, resulting in menus
> without a border and unexpectedly large item padding. Regression due to
> the combination of r344651, r345479, and r360168.
> 
> Note this means --open-ash on Desktop Linux, and Metro mode on Windows,
> will use non-Ash menus. See screenshots at http://crbug.com/544550#c13
> 
> BUG=415953, 544550
> 
> Committed: https://crrev.com/5d23f8c18f1d9fbf1655ece40b31d59dea443c60
> Cr-Commit-Position: refs/heads/master@{#363924}

TBR=sky@chromium.org,estade@chromium.org,tapted@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=415953, 544550
==========

to

==========
Revert of Use a single views::MenuConfig instance for each platform (patchset #7
id:140001 of https://codereview.chromium.org/1477253002/ )

Reason for revert:
This broke compilation on
https://build.chromium.org/p/chromium.android/builders/Android%20Aura%20Build...
(the patch landed in an earlier build, but was masked by another compile failure
:-|):

../../ui/views/controls/menu/menu_config.cc:45: error: undefined reference to
'views::MenuConfig::Init()'

Original issue's description:
> Use a single views::MenuConfig instance for each platform
> 
> Most noticeably, always use the GTK-style menu layout on Desktop Linux.
> 
> Previously, the MenuConfig used by a particular MenuItemView could be
> affected by that View's Widget's GetNativeTheme().
> 
> This once allowed a menu to decide whether to use a ChromeOS-style menu
> or a native Desktop-style menu config on the same platform. But that's
> no longer needed, and makes trouble with the "Classic Theme" in Desktop
> Linux. (e.g. because menus are not always in a Widget when they are
> configured, so the native theme is hard to determine.)
> 
> Using a single instance simplifies things and fixes a regression where
> the Ash-style was being used on Desktop Linux, resulting in menus
> without a border and unexpectedly large item padding. Regression due to
> the combination of r344651, r345479, and r360168.
> 
> Note this means --open-ash on Desktop Linux, and Metro mode on Windows,
> will use non-Ash menus. See screenshots at http://crbug.com/544550#c13
> 
> BUG=415953, 544550
> 
> Committed: https://crrev.com/5d23f8c18f1d9fbf1655ece40b31d59dea443c60
> Cr-Commit-Position: refs/heads/master@{#363924}

TBR=sky@chromium.org,estade@chromium.org,tapted@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=415953, 544550
==========

[commit-bot: I haz the power, 2015-12-10 16:12:07]

Committed patchset #2 (id:280001)

[commit-bot: I haz the power, 2015-12-10 16:12:51]

Description was changed from

==========
Revert of Use a single views::MenuConfig instance for each platform (patchset #7
id:140001 of https://codereview.chromium.org/1477253002/ )

Reason for revert:
This broke compilation on
https://build.chromium.org/p/chromium.android/builders/Android%20Aura%20Build...
(the patch landed in an earlier build, but was masked by another compile failure
:-|):

../../ui/views/controls/menu/menu_config.cc:45: error: undefined reference to
'views::MenuConfig::Init()'

Original issue's description:
> Use a single views::MenuConfig instance for each platform
> 
> Most noticeably, always use the GTK-style menu layout on Desktop Linux.
> 
> Previously, the MenuConfig used by a particular MenuItemView could be
> affected by that View's Widget's GetNativeTheme().
> 
> This once allowed a menu to decide whether to use a ChromeOS-style menu
> or a native Desktop-style menu config on the same platform. But that's
> no longer needed, and makes trouble with the "Classic Theme" in Desktop
> Linux. (e.g. because menus are not always in a Widget when they are
> configured, so the native theme is hard to determine.)
> 
> Using a single instance simplifies things and fixes a regression where
> the Ash-style was being used on Desktop Linux, resulting in menus
> without a border and unexpectedly large item padding. Regression due to
> the combination of r344651, r345479, and r360168.
> 
> Note this means --open-ash on Desktop Linux, and Metro mode on Windows,
> will use non-Ash menus. See screenshots at http://crbug.com/544550#c13
> 
> BUG=415953, 544550
> 
> Committed: https://crrev.com/5d23f8c18f1d9fbf1655ece40b31d59dea443c60
> Cr-Commit-Position: refs/heads/master@{#363924}

TBR=sky@chromium.org,estade@chromium.org,tapted@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=415953, 544550
==========

to

==========
Revert of Use a single views::MenuConfig instance for each platform (patchset #7
id:140001 of https://codereview.chromium.org/1477253002/ )

Reason for revert:
This broke compilation on
https://build.chromium.org/p/chromium.android/builders/Android%20Aura%20Build...
(the patch landed in an earlier build, but was masked by another compile failure
:-|):

../../ui/views/controls/menu/menu_config.cc:45: error: undefined reference to
'views::MenuConfig::Init()'

Original issue's description:
> Use a single views::MenuConfig instance for each platform
>
> Most noticeably, always use the GTK-style menu layout on Desktop Linux.
>
> Previously, the MenuConfig used by a particular MenuItemView could be
> affected by that View's Widget's GetNativeTheme().
>
> This once allowed a menu to decide whether to use a ChromeOS-style menu
> or a native Desktop-style menu config on the same platform. But that's
> no longer needed, and makes trouble with the "Classic Theme" in Desktop
> Linux. (e.g. because menus are not always in a Widget when they are
> configured, so the native theme is hard to determine.)
>
> Using a single instance simplifies things and fixes a regression where
> the Ash-style was being used on Desktop Linux, resulting in menus
> without a border and unexpectedly large item padding. Regression due to
> the combination of r344651, r345479, and r360168.
>
> Note this means --open-ash on Desktop Linux, and Metro mode on Windows,
> will use non-Ash menus. See screenshots at http://crbug.com/544550#c13
>
> BUG=415953, 544550
>
> Committed: https://crrev.com/5d23f8c18f1d9fbf1655ece40b31d59dea443c60
> Cr-Commit-Position: refs/heads/master@{#363924}

TBR=sky@chromium.org,estade@chromium.org,tapted@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=415953, 544550

Committed: https://crrev.com/2903ab2c274a0246c603b1b29d9967d3c9c8ff00
Cr-Commit-Position: refs/heads/master@{#364371}
==========

[commit-bot: I haz the power, 2015-12-10 16:12:52]

Patchset 2 (id:??) landed as
https://crrev.com/2903ab2c274a0246c603b1b29d9967d3c9c8ff00
Cr-Commit-Position: refs/heads/master@{#364371}