ui/views/controls/combobox/combobox.cc - Issue 1514693006: Revert of Use a single views::MenuConfig instance for each platform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/combobox/combobox.cc

Issue 1514693006: Revert of Use a single views::MenuConfig instance for each platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase revert on https://codereview.chromium.org/1504743003 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/combobox/combobox.cc

diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc

index 2074b0ef16c3899e3e2d8f4426a0e15438e5fdd3..51b17e53f25fd4c50e3372e799913ca9c88d8f3b 100644

--- a/ui/views/controls/combobox/combobox.cc

+++ b/ui/views/controls/combobox/combobox.cc

@@ -233,7 +233,8 @@ class Combobox::ComboboxMenuModelAdapter : public ui::MenuModel,

private:

bool UseCheckmarks() const {

return owner_->style_ != STYLE_ACTION &&

- MenuConfig::instance().check_selected_combobox_item;

+ MenuConfig::instance(owner_->GetNativeTheme())

+ .check_selected_combobox_item;

}

// Overridden from MenuModel:

« no previous file with comments | « ui/views/cocoa/bridged_content_view.mm ('k') | ui/views/controls/menu/menu_config.h » ('j') | no next file with comments »