Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java

Issue 1514603004: Reader Mode cannot be permanently disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
index f5a77d62df2767532439e62833899c69f7ebd8df..2f1ab7b68206399c89ca27c59fbe9154f4d53488 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
@@ -276,15 +276,9 @@ public class ReaderModeManager extends TabModelSelectorTabObserver
@Override
public void onCloseButtonPressed() {
- int currentTabId = mTabModelSelector.getCurrentTabId();
- if (currentTabId == Tab.INVALID_TAB_ID) return;
-
- if (!mTabStatusMap.containsKey(currentTabId)) return;
- ReaderModeTabInfo tabInfo = mTabStatusMap.get(currentTabId);
- tabInfo.setIsDismissed(true);
- if (tabInfo.getWebContentsObserver() != null) {
- tabInfo.getWebContentsObserver().destroy();
- }
+ // TODO(mdjones): Add user metrics for using the close button in the panel bar here.
+ // TODO(mdjones): If it is decided that Reader Mode cannot be permanently dismissed for a
+ // tab, remove that remaining logic from this class.
}
@Override
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698