Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1514583004: Clean up CSSParserContext arguments in property parsing code (Closed)

Created:
5 years ago by Timothy Loh
Modified:
5 years ago
Reviewers:
Eric Willigers, rwlbuis
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up CSSParserContext arguments in property parsing code This patch cleans up CSSParserContext arguments in the property parser, tightening them to the CSSParserMode if possible, and replacing values by const refs to avoid unneeded copies. BUG=499780 Committed: https://crrev.com/fd8931ee10c1f9ed2bd48deca4b5eec27dd6adbd Cr-Commit-Position: refs/heads/master@{#364289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -37 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 24 chunks +34 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Timothy Loh
5 years ago (2015-12-10 04:01:49 UTC) #2
Eric Willigers
lgtm
5 years ago (2015-12-10 04:11:58 UTC) #3
rwlbuis
Lgtm. Btw, are you sure this is compatible with the CSS Property API patch? AFAIK ...
5 years ago (2015-12-10 04:17:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514583004/1
5 years ago (2015-12-10 04:18:27 UTC) #6
Timothy Loh
On 2015/12/10 04:17:55, rwlbuis wrote: > Lgtm. > > Btw, are you sure this is ...
5 years ago (2015-12-10 04:19:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 05:50:56 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-10 05:51:32 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd8931ee10c1f9ed2bd48deca4b5eec27dd6adbd
Cr-Commit-Position: refs/heads/master@{#364289}

Powered by Google App Engine
This is Rietveld 408576698