Fix nocompile base_unittests

Fix nocompile base_unittests

* Rebaseline nocompile test expectation in base_unittests
* Disable scoped_ptr for sized array, which was accidentally enabled.

BUG=

Committed: https://crrev.com/096369a627f27da971e0f676cc3196d66e3dad50
Cr-Commit-Position: refs/heads/master@{#364637}

[tzik, 2015-12-10 09:59:52]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-10 10:00:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514573005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514573005/1

[commit-bot: I haz the power, 2015-12-10 10:20:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 10:20:11]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[tzik, 2015-12-10 10:44:46]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-10 10:44:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514573005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514573005/20001

[tzik, 2015-12-10 11:09:11]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-10 11:09:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514573005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514573005/40001

[commit-bot: I haz the power, 2015-12-10 11:42:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 11:42:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tzik, 2015-12-10 14:53:52]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-10 14:54:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514573005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514573005/80001

[tzik, 2015-12-10 14:55:51]

Description was changed from

==========
Fix nocompile base_unittests

BUG=
==========

to

==========
Fix nocompile base_unittests

* Rebaseline nocompile test expectation in base_unittests
* Disable scoped_ptr for sized array, which was accidentally enabled.

BUG=
==========

[tzik, 2015-12-10 14:55:51]

tzik@chromium.org changed reviewers:
+ dcheng@chromium.org

[tzik, 2015-12-10 14:56:02]

PTAL

[dcheng, 2015-12-10 18:19:40]

lgtm

https://codereview.chromium.org/1514573005/diff/80001/base/memory/scoped_ptr.h
File base/memory/scoped_ptr.h (right):

https://codereview.chromium.org/1514573005/diff/80001/base/memory/scoped_ptr....
base/memory/scoped_ptr.h:243: static_assert(!std::is_array<T>::value,
!!!

thanks

[danakj, 2015-12-10 19:13:05]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-12-10 19:13:05]

LGTM why aren't these being run by bots or locally for me?

[danakj, 2015-12-10 19:22:30]

Oh :(

Currently the no compile tests don't run at all. In order to test your
no-compile tests, you need to edit build/nocompile.gypi and remove the line
containing "crbug.com/105388" as well as next line.

Same for GN I guess

[commit-bot: I haz the power, 2015-12-10 19:38:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 19:38:52]

Dry run: This issue passed the CQ dry run.

[dcheng, 2015-12-10 19:39:38]

Yeah, when we tried enabling them they were flaky on the bots. As it
stands, there is not even a GN equivalent =(

On Thu, Dec 10, 2015, 11:22  <danakj@chromium.org> wrote:

> Oh :(
>
> Currently the no compile tests don't run at all. In order to test your
> no-compile tests, you need to edit build/nocompile.gypi and remove the line
> containing "crbug.com/105388" as well as next line.
>
> Same for GN I guess
>
> https://codereview.chromium.org/1514573005/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tzik, 2015-12-11 06:32:10]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2015-12-11 06:33:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514573005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514573005/80001

[commit-bot: I haz the power, 2015-12-11 06:39:14]

Description was changed from

==========
Fix nocompile base_unittests

* Rebaseline nocompile test expectation in base_unittests
* Disable scoped_ptr for sized array, which was accidentally enabled.

BUG=
==========

to

==========
Fix nocompile base_unittests

* Rebaseline nocompile test expectation in base_unittests
* Disable scoped_ptr for sized array, which was accidentally enabled.

BUG=
==========

[commit-bot: I haz the power, 2015-12-11 06:39:15]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-11 06:40:03]

Description was changed from

==========
Fix nocompile base_unittests

* Rebaseline nocompile test expectation in base_unittests
* Disable scoped_ptr for sized array, which was accidentally enabled.

BUG=
==========

to

==========
Fix nocompile base_unittests

* Rebaseline nocompile test expectation in base_unittests
* Disable scoped_ptr for sized array, which was accidentally enabled.

BUG=

Committed: https://crrev.com/096369a627f27da971e0f676cc3196d66e3dad50
Cr-Commit-Position: refs/heads/master@{#364637}
==========

[commit-bot: I haz the power, 2015-12-11 06:40:04]

Patchset 5 (id:??) landed as
https://crrev.com/096369a627f27da971e0f676cc3196d66e3dad50
Cr-Commit-Position: refs/heads/master@{#364637}