base/memory/scoped_ptr.h - Issue 1514573005: Fix nocompile base_unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/scoped_ptr.h

Issue 1514573005: Fix nocompile base_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/memory/scoped_ptr.h

diff --git a/base/memory/scoped_ptr.h b/base/memory/scoped_ptr.h

index 269c5a3db18c0ccd3af1b3b839a1afb4650b60e9..ac27a795c2237c312caea11c09ea8608d2d53ae6 100644

--- a/base/memory/scoped_ptr.h

+++ b/base/memory/scoped_ptr.h

@@ -240,6 +240,8 @@ template <class T, class D = std::default_delete<T>>

class scoped_ptr {

DISALLOW_COPY_AND_ASSIGN_WITH_MOVE_FOR_BIND(scoped_ptr)

+ static_assert(!std::is_array<T>::value,

dcheng 2015/12/10 18:19:40 !!! thanks

+ "scoped_ptr doesn't support array with size");

static_assert(base::internal::IsNotRefCounted<T>::value,

"T is a refcounted type and needs a scoped_refptr");

« no previous file with comments | « base/callback_list_unittest.nc ('k') | base/memory/scoped_ptr_unittest.nc » ('j') | no next file with comments »