Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1514573002: Reland of ll clang 254049:254793 (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
hans, engedy
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of ll clang 254049:254793 (patchset #1 id:1 of https://codereview.chromium.org/1508403002/ ) Reason for revert: Should work with CFI reverted. Original issue's description: > Revert of roll clang 254049:254793 (patchset #3 id:40001 of https://codereview.chromium.org/1507873002/ ) > > Reason for revert: > Speculative revert to see if this fixes link error on 'Google Chrome Linux x64'. Please see first comment on the revert CL for more info. > > Original issue's description: > > roll clang 254049:254793 > > > > This switches msan to the new ABI. > > > > It's also the first roll that used update.py instead of > > update.sh to build the packages. > > > > It also changes package.py to bundle up libstdc++ on linux > > unconditionally, and removes the --gcc-toolchain flag from > > it (the auto-downloaded gcc should be good enough; > > one fewer thing I can get wrong). > > > > BUG=565541 > > > > Committed: https://crrev.com/3c862a1dff6cbe5f693ba788cdc71770d408e7b7 > > Cr-Commit-Position: refs/heads/master@{#363986} > > TBR=hans@chromium.org,thakis@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=565541 > > Committed: https://crrev.com/af4e20d002ee9acc62854db5bd89f2aa14b2d419 > Cr-Commit-Position: refs/heads/master@{#364051} TBR=hans@chromium.org,engedy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=565541 Committed: https://crrev.com/94ba71d936b63c60eb6b24a1268af559f05d503b Cr-Commit-Position: refs/heads/master@{#364069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -34 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M build/config/sanitizers/BUILD.gn View 2 chunks +1 line, -9 lines 0 comments Download
M third_party/instrumented_libraries/binaries/msan-chained-origins-precise.tgz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/instrumented_libraries/binaries/msan-chained-origins-trusty.tgz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/instrumented_libraries/binaries/msan-no-origins-precise.tgz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/instrumented_libraries/binaries/msan-no-origins-trusty.tgz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/package.py View 4 chunks +2 lines, -10 lines 0 comments Download
M tools/clang/scripts/update.py View 3 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Created Reland of ll clang 254049:254793
5 years ago (2015-12-09 15:35:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514573002/1
5 years ago (2015-12-09 15:36:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 15:38:36 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-09 15:39:27 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94ba71d936b63c60eb6b24a1268af559f05d503b
Cr-Commit-Position: refs/heads/master@{#364069}

Powered by Google App Engine
This is Rietveld 408576698