chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java - Issue 1514453007: Show more stack trace in instrumentation tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java

Issue 1514453007: Show more stack trace in instrumentation tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add command-line flag. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/pylib/instrumentation/instrumentation_test_instance.py ('K') | « build/android/pylib/instrumentation/instrumentation_test_instance_test.py ('k') | chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java » ('j') | chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java

index bf07298721815e6fb56b356c6244279fccffc839..516504e504078220d9d74c8cfee70c53a73cc106 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java

@@ -44,6 +44,9 @@ public class ChromeStrictMode {

if ("death".equals(commandLine.getSwitchValue(ChromeSwitches.STRICT_MODE))) {

threadPolicy = threadPolicy.penaltyDeath();

vmPolicy = vmPolicy.penaltyDeath();

+ } else if ("testing".equals(commandLine.getSwitchValue(ChromeSwitches.STRICT_MODE))) {

+ threadPolicy = threadPolicy.penaltyDeath();

+ // Currently VmDeathPolicy kills the process, and is not visible on bot test output.

}

StrictMode.setThreadPolicy(threadPolicy.build());

StrictMode.setVmPolicy(vmPolicy.build());