build/android/pylib/instrumentation/instrumentation_test_instance.py - Issue 1514453007: Show more stack trace in instrumentation tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 1514453007: Show more stack trace in instrumentation tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add command-line flag. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | build/android/pylib/instrumentation/instrumentation_test_instance_test.py » ('j') | chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/instrumentation/instrumentation_test_instance.py

diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py

index b13fdb28f3400c07175e9010f90d207d3116bdb2..3d33b70d6da378ddef0b32df8e5bc07209759ae6 100644

--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py

+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py

@@ -101,9 +101,11 @@ def GenerateTestResults(

current_result = None

+ test_class = None

+ test_method = None

for status_code, bundle in statuses:

- test_class = bundle.get('class', '')

- test_method = bundle.get('test', '')

+ test_class = bundle.get('class', '') or test_class

jbudorick 2015/12/11 21:04:30 nit if this logic sticks around: just do test_c

Peter Wen 2015/12/11 22:07:21 Acknowledged.

+ test_method = bundle.get('test', '') or test_method

jbudorick 2015/12/11 21:04:30 nit: same

Peter Wen 2015/12/11 22:07:21 Acknowledged.

if test_class and test_method:

test_name = '%s#%s' % (test_class, test_method)

else: