Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: build/config/BUILDCONFIG.gn

Issue 1514423003: Don't set -fvisibility=hidden for iOS Debug. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update gn Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILDCONFIG.gn
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index 54bf3722fa5c5c1197e790834d0154279a804dee..a90228fb54e8b356e10ad5ec43bc679e2b40204a 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -472,10 +472,13 @@ if (current_os == "winrt_81" || current_os == "winrt_81_phone" ||
_native_compiler_configs += [ "//build/config/win:target_winrt" ]
}
if (is_posix) {
- _native_compiler_configs += [
- "//build/config/gcc:no_exceptions",
- "//build/config/gcc:symbol_visibility_hidden",
- ]
+ _native_compiler_configs += [ "//build/config/gcc:no_exceptions" ]
+
+ # XCTests require symbols to not be hidden.
+ if (!is_ios || is_release) {
+ _native_compiler_configs +=
+ [ "//build/config/gcc:symbol_visibility_hidden" ]
brettw 2015/12/12 23:53:18 Let's do this: make a new config in build/config/g
baxley 2015/12/14 18:46:52 Done. Thanks for the detailed explanation.
+ }
}
if (is_android) {
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698