Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Side by Side Diff: build/config/BUILDCONFIG.gn

Issue 1514423003: Don't set -fvisibility=hidden for iOS Debug. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update gn Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # ============================================================================= 5 # =============================================================================
6 # PLATFORM SELECTION 6 # PLATFORM SELECTION
7 # ============================================================================= 7 # =============================================================================
8 # 8 #
9 # There are two main things to set: "os" and "cpu". The "toolchain" is the name 9 # There are two main things to set: "os" and "cpu". The "toolchain" is the name
10 # of the GN thing that encodes combinations of these things. 10 # of the GN thing that encodes combinations of these things.
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 "//build/config/win:nominmax", 465 "//build/config/win:nominmax",
466 "//build/config/win:unicode", 466 "//build/config/win:unicode",
467 "//build/config/win:winver", 467 "//build/config/win:winver",
468 ] 468 ]
469 } 469 }
470 if (current_os == "winrt_81" || current_os == "winrt_81_phone" || 470 if (current_os == "winrt_81" || current_os == "winrt_81_phone" ||
471 current_os == "winrt_10") { 471 current_os == "winrt_10") {
472 _native_compiler_configs += [ "//build/config/win:target_winrt" ] 472 _native_compiler_configs += [ "//build/config/win:target_winrt" ]
473 } 473 }
474 if (is_posix) { 474 if (is_posix) {
475 _native_compiler_configs += [ 475 _native_compiler_configs += [ "//build/config/gcc:no_exceptions" ]
476 "//build/config/gcc:no_exceptions", 476
477 "//build/config/gcc:symbol_visibility_hidden", 477 # XCTests require symbols to not be hidden.
478 ] 478 if (!is_ios || is_release) {
479 _native_compiler_configs +=
480 [ "//build/config/gcc:symbol_visibility_hidden" ]
brettw 2015/12/12 23:53:18 Let's do this: make a new config in build/config/g
baxley 2015/12/14 18:46:52 Done. Thanks for the detailed explanation.
481 }
479 } 482 }
480 483
481 if (is_android) { 484 if (is_android) {
482 _native_compiler_configs += 485 _native_compiler_configs +=
483 [ "//build/config/android:default_cygprofile_instrumentation" ] 486 [ "//build/config/android:default_cygprofile_instrumentation" ]
484 } 487 }
485 488
486 if (is_clang && !is_nacl) { 489 if (is_clang && !is_nacl) {
487 _native_compiler_configs += [ 490 _native_compiler_configs += [
488 "//build/config/clang:find_bad_constructs", 491 "//build/config/clang:find_bad_constructs",
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
585 forward_variables_from(invoker, "*") 588 forward_variables_from(invoker, "*")
586 589
587 # All shared libraries must have the sanitizer deps to properly link in 590 # All shared libraries must have the sanitizer deps to properly link in
588 # asan mode (this target will be empty in other cases). 591 # asan mode (this target will be empty in other cases).
589 if (!defined(deps)) { 592 if (!defined(deps)) {
590 deps = [] 593 deps = []
591 } 594 }
592 deps += [ "//build/config/sanitizers:deps" ] 595 deps += [ "//build/config/sanitizers:deps" ]
593 } 596 }
594 } 597 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698