Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1514193003: Clean up remnants of direct use of PNACL_BROWSER_TRANSLATOR (Closed)

Created:
5 years ago by rkotlerimgtec
Modified:
5 years ago
Reviewers:
Karl, Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/IceCompiler.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rkotlerimgtec
5 years ago (2015-12-11 00:08:47 UTC) #3
Karl
lgtm
5 years ago (2015-12-11 16:44:04 UTC) #5
Jim Stichnoth
lgtm
5 years ago (2015-12-11 17:27:20 UTC) #6
Jim Stichnoth
Committed patchset #1 (id:1) manually as 8dbb4a0af56e047a1f3a86bcc46939dad2f02691 (presubmit successful).
5 years ago (2015-12-11 17:51:52 UTC) #8
rkotlerimgtec
I can't push the changes myself upstream. On Fri, Dec 11, 2015 at 8:44 AM, ...
5 years ago (2015-12-11 18:18:54 UTC) #9
Jim Stichnoth
On 2015/12/11 18:18:54, rkotlerimgtec wrote: > I can't push the changes myself upstream. Right, for ...
5 years ago (2015-12-11 18:32:36 UTC) #10
rkotlerimgtec
5 years ago (2015-12-11 19:21:44 UTC) #11
Message was sent while issue was closed.
thanks.

On Fri, Dec 11, 2015 at 10:32 AM, <stichnot@chromium.org> wrote:

> On 2015/12/11 18:18:54, rkotlerimgtec wrote:
>
>> I can't push the changes myself upstream.
>>
>
> Right, for all these you can count on me to land the change on your
> behalf, and
> hopefully I remember to use the right flags to attribute it to you in the
> git
> history.
>
> https://codereview.chromium.org/1514193003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

Powered by Google App Engine
This is Rietveld 408576698