Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: src/IceCompiler.cpp

Issue 1514193003: Clean up remnants of direct use of PNACL_BROWSER_TRANSLATOR (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceCompiler.cpp
diff --git a/src/IceCompiler.cpp b/src/IceCompiler.cpp
index adccfd2c4121547835e9bb83f28679f100adb609..82f99a917c02e8fcab4fa037442e766dca309cd7 100644
--- a/src/IceCompiler.cpp
+++ b/src/IceCompiler.cpp
@@ -19,6 +19,7 @@
#include "IceCompiler.h"
+#include "IceBuildDefs.h"
#include "IceCfg.h"
#include "IceClFlags.h"
#include "IceClFlagsExtra.h"
@@ -51,7 +52,7 @@ struct {
{"llvm_ir", BuildDefs::llvmIr()},
{"llvm_ir_as_input", BuildDefs::llvmIrAsInput()},
{"minimal_build", BuildDefs::minimal()},
- {"browser_mode", PNACL_BROWSER_TRANSLATOR}};
+ {"browser_mode", BuildDefs::browser()}};
// Validates values of build attributes. Prints them to Stream if Stream is
// non-null.
@@ -133,7 +134,7 @@ void Compiler::run(const Ice::ClFlagsExtra &ExtraFlags, GlobalContext &Ctx,
PTranslator->translate(IRFilename, std::move(MemObj));
Translator.reset(PTranslator.release());
} else if (BuildDefs::llvmIr()) {
- if (PNACL_BROWSER_TRANSLATOR) {
+ if (BuildDefs::browser()) {
Ctx.getStrError()
<< "non BuildOnRead is not supported w/ PNACL_BROWSER_TRANSLATOR\n";
return Ctx.getErrorStatus()->assign(EC_Args);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698