New Mojom parser: Don't allow enum variables to be assigned int values.

New Mojom parser: Don't allow enum variables to be assigned int values.

Thus far the new Mojom parser has allowed variables of enum type to be assigned integer values. This used to be allowed in .mojom files but that was changed a few months back and the new parser never picked up that change. This patch corrects that.

- Because IsAssignmentCompatible() now returns false in the case of assigning an int to an enum, it is necessary to not use IsAssignmentCompatible() in the case that a user-defined constant that resolves to an int is being used as an enum value initializer (because that is allowed). That explains the reorganization in UserValueRef.validateAfterResolution().

- We changed how assignments of literals to user-defined-types is handled. Previously we did some validation during parsing (for example we would check that the literal was not of type float) but left other validation for the later validation phase. We now due all validation during the later validation phase.

BUG=#46
R=azani@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/e27aa4fef1a5e79ca8caa433e86945f808452fa0

[rudominer, 2015-12-10 23:36:27]

Patchset #1 (id:1) has been deleted

[rudominer, 2015-12-10 23:39:06]

Description was changed from

==========
New Mojom parser: Don't allow enum variables to be assigned int values.

Thus far the new Mojom parser has allowed variables of enum type to be assigned
integer values. This used to be allowed in .mojom files but that was changed a
few months back and the new parser never picked up that change. This patch
corrects that.

- Because IsAssignmentCompatible() now returns false in the case of assigning an
int to an enum, it is necessary to not use IsAssignmentCompatible() in the case
that a user-defined constant that resolves to an int is being used as an enum
value initializer (because that is allowed). That explains the reorganization in
UserValueRef.validateAfterResolution().

BUG=#46
==========

to

==========
New Mojom parser: Don't allow enum variables to be assigned int values.

Thus far the new Mojom parser has allowed variables of enum type to be assigned
integer values. This used to be allowed in .mojom files but that was changed a
few months back and the new parser never picked up that change. This patch
corrects that.

- Because IsAssignmentCompatible() now returns false in the case of assigning an
int to an enum, it is necessary to not use IsAssignmentCompatible() in the case
that a user-defined constant that resolves to an int is being used as an enum
value initializer (because that is allowed). That explains the reorganization in
UserValueRef.validateAfterResolution().

- We changed how assignments of literals to user-defined-types is handled.
Previously we did some validation during parsing (for example we would check
that the literal was not of type float) but left other validation for the later
validation phase. We now due all validation during the later validation phase.

BUG=#46
==========

[rudominer, 2015-12-10 23:39:19]

Hi Alex, ptal.

[azani, 2015-12-10 23:59:17]

azani@chromium.org changed reviewers:
+ azani@chromium.org

[azani, 2015-12-10 23:59:17]

lgtm

[rudominer, 2015-12-11 00:00:15]

Description was changed from

==========
New Mojom parser: Don't allow enum variables to be assigned int values.

Thus far the new Mojom parser has allowed variables of enum type to be assigned
integer values. This used to be allowed in .mojom files but that was changed a
few months back and the new parser never picked up that change. This patch
corrects that.

- Because IsAssignmentCompatible() now returns false in the case of assigning an
int to an enum, it is necessary to not use IsAssignmentCompatible() in the case
that a user-defined constant that resolves to an int is being used as an enum
value initializer (because that is allowed). That explains the reorganization in
UserValueRef.validateAfterResolution().

- We changed how assignments of literals to user-defined-types is handled.
Previously we did some validation during parsing (for example we would check
that the literal was not of type float) but left other validation for the later
validation phase. We now due all validation during the later validation phase.

BUG=#46
==========

to

==========
New Mojom parser: Don't allow enum variables to be assigned int values.

Thus far the new Mojom parser has allowed variables of enum type to be assigned
integer values. This used to be allowed in .mojom files but that was changed a
few months back and the new parser never picked up that change. This patch
corrects that.

- Because IsAssignmentCompatible() now returns false in the case of assigning an
int to an enum, it is necessary to not use IsAssignmentCompatible() in the case
that a user-defined constant that resolves to an int is being used as an enum
value initializer (because that is allowed). That explains the reorganization in
UserValueRef.validateAfterResolution().

- We changed how assignments of literals to user-defined-types is handled.
Previously we did some validation during parsing (for example we would check
that the literal was not of type float) but left other validation for the later
validation phase. We now due all validation during the later validation phase.

BUG=#46
R=azani@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/e27aa4fef1a5e79ca8caa433e86...
==========

[rudominer, 2015-12-11 00:00:16]

Committed patchset #1 (id:20001) manually as
e27aa4fef1a5e79ca8caa433e86945f808452fa0 (presubmit successful).