mojom/mojom_parser/mojom/user_defined_types_test.go - Issue 1514173002: New Mojom parser: Don't allow enum variables to be assigned int values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojom/mojom_parser/mojom/user_defined_types_test.go

Issue 1514173002: New Mojom parser: Don't allow enum variables to be assigned int values. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: working on stuff Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojom/mojom_parser/mojom/user_defined_types_test.go

diff --git a/mojom/mojom_parser/mojom/user_defined_types_test.go b/mojom/mojom_parser/mojom/user_defined_types_test.go

index 8cacc1f10131bf5adc2d38db1601265b495e6cae..b0b83a409c968b7e7f4048d83875acf6c42344ee 100644

--- a/mojom/mojom_parser/mojom/user_defined_types_test.go

+++ b/mojom/mojom_parser/mojom/user_defined_types_test.go

@@ -61,7 +61,7 @@ func TestIsAssignmentCompatibleWith(t *testing.T) {

{NewTestStruct("struct"), []bool{false, false, false, false, true}},

{NewTestInterface("interface"), []bool{false, false, false, false, false}},

{NewTestUnion("union"), []bool{false, false, false, false, true}},

- {NewTestEnum("enum"), []bool{false, false, true, false, true}},

+ {NewTestEnum("enum"), []bool{false, false, false, false, false}},

}

for _, c := range cases {

for i, v := range literalValues {

« no previous file with comments | « mojom/mojom_parser/mojom/user_defined_types.go ('k') | mojom/mojom_parser/parser/parser_test.go » ('j') | no next file with comments »