core/include/fpdfapi/fpdf_objects.h - Issue 1514093002: Fix memory leaks involving InsertIndirectObject()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fpdfapi/fpdf_objects.h

Issue 1514093002: Fix memory leaks involving InsertIndirectObject() (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fpdfapi/fpdf_objects.h

diff --git a/core/include/fpdfapi/fpdf_objects.h b/core/include/fpdfapi/fpdf_objects.h

index 532ede2a08a222d9af7812f3d8cb32390590140f..ba2bbb3fab1ea15258be2efbe993e9cf630a7cae 100644

--- a/core/include/fpdfapi/fpdf_objects.h

+++ b/core/include/fpdfapi/fpdf_objects.h

@@ -609,7 +609,7 @@ class CPDF_IndirectObjects {

void ReleaseIndirectObject(FX_DWORD objnum);

- void InsertIndirectObject(FX_DWORD objnum, CPDF_Object* pObj);

+ FX_BOOL InsertIndirectObject(FX_DWORD objnum, CPDF_Object* pObj);

Tom Sepez 2015/12/10 17:32:12 nit: add a comment // Takes ownership of |pObj|.

jun_fang 2015/12/10 23:24:26 Acknowledged.

FX_DWORD GetLastObjNum() const;