Fix memory leaks involving InsertIndirectObject()

core/include/fpdfapi/fpdf_objects.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_INCLUDE_FPDFAPI_FPDF_OBJECTS_H_
 #define CORE_INCLUDE_FPDFAPI_FPDF_OBJECTS_H_
 
 #include "core/include/fxcrt/fx_coordinates.h"
@@ skipping 591 matching lines @@
 
   CPDF_Object* GetIndirectObject(FX_DWORD objnum,
                                  struct PARSE_CONTEXT* pContext = NULL);
 
   int GetIndirectType(FX_DWORD objnum);
 
   FX_DWORD AddIndirectObject(CPDF_Object* pObj);
 
   void ReleaseIndirectObject(FX_DWORD objnum);
 
-  void InsertIndirectObject(FX_DWORD objnum, CPDF_Object* pObj);
+  FX_BOOL InsertIndirectObject(FX_DWORD objnum, CPDF_Object* pObj);

[Tom Sepez, 2015/12/10 17:32:12]

nit: add a comment 
// Takes ownership of |pObj|.

[jun_fang, 2015/12/10 23:24:26]

Acknowledged.

 
   FX_DWORD GetLastObjNum() const;
 
   FX_POSITION GetStartPosition() const {
     return m_IndirectObjs.GetStartPosition();
   }
 
   void GetNextAssoc(FX_POSITION& rPos,
                     FX_DWORD& objnum,
                     CPDF_Object*& pObject) const {
     m_IndirectObjs.GetNextAssoc(rPos, (void*&)objnum, (void*&)pObject);
   }
 
  protected:
   CFX_MapPtrToPtr m_IndirectObjs;
 
   CPDF_Parser* m_pParser;
 
   FX_DWORD m_LastObjNum;
 };
 
 #endif  // CORE_INCLUDE_FPDFAPI_FPDF_OBJECTS_H_