Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1513943005: Tweaks for hover. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tweaks for hover. 1. Include full signature of classes - extends, with and implements clauses. 2. Provide statis type only for variables - for all other elements the static type is always the same as in the signature. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/168556a3e44364ac02555b4b3aec3d5821fb1545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -12 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_hover_test.dart View 6 chunks +34 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_hover_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-11 22:20:04 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-11 22:25:01 UTC) #2
scheglov
5 years ago (2015-12-11 22:25:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
168556a3e44364ac02555b4b3aec3d5821fb1545 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698