Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: pkg/analysis_server/test/analysis/get_hover_test.dart

Issue 1513943005: Tweaks for hover. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/analysis/get_hover_test.dart
diff --git a/pkg/analysis_server/test/analysis/get_hover_test.dart b/pkg/analysis_server/test/analysis/get_hover_test.dart
index cc5befe7bf4cac9afe2d42d3ffe4821dafab582e..030252be2f71ee88fb93e9ca6a3ea2fb509d2a08 100644
--- a/pkg/analysis_server/test/analysis/get_hover_test.dart
+++ b/pkg/analysis_server/test/analysis/get_hover_test.dart
@@ -41,6 +41,35 @@ class AnalysisHoverTest extends AbstractAnalysisTest {
createProject();
}
+ test_class() async {
+ addTestFile('''
+class A<E> {}
+class I1<K, V> {}
+class I2<E> {}
+class M1 {}
+class M2<E> {}
+class B<T> extends A<T> with M1, M2<int> implements I1<int, String>, I2 {}
+''');
+ HoverInformation hover = await prepareHover('B<T>');
+ expect(
+ hover.elementDescription,
+ 'class B<T> extends A<T> with M1, M2<int> '
+ 'implements I1<int, String>, I2');
+ expect(hover.staticType, isNull);
+ expect(hover.propagatedType, isNull);
+ }
+
+ test_class_abstract() async {
+ addTestFile('''
+class A {}
+abstract class B extends A {}
+''');
+ HoverInformation hover = await prepareHover('B extends');
+ expect(hover.elementDescription, 'abstract class B extends A');
+ expect(hover.staticType, isNull);
+ expect(hover.propagatedType, isNull);
+ }
+
test_dartdoc_clunky() async {
addTestFile('''
library my.library;
@@ -84,7 +113,7 @@ List<String> fff(int a, String b) {
expect(hover.elementDescription, 'fff(int a, String b) → List<String>');
expect(hover.elementKind, 'function');
// types
- expect(hover.staticType, '(int, String) → List<String>');
+ expect(hover.staticType, isNull);
expect(hover.propagatedType, isNull);
// no parameter
expect(hover.parameter, isNull);
@@ -128,7 +157,7 @@ class A {
expect(hover.elementDescription, 'mmm(int a, String b) → List<String>');
expect(hover.elementKind, 'method');
// types
- expect(hover.staticType, '(int, String) → List<String>');
+ expect(hover.staticType, isNull);
expect(hover.propagatedType, isNull);
// no parameter
expect(hover.parameter, isNull);
@@ -185,7 +214,7 @@ class A {
expect(hover.parameter, isNull);
}
- test_expression_syntheticGetter() async {
+ test_expression_syntheticGetter_invocation() async {
addTestFile('''
library my.library;
class A {
@@ -275,7 +304,7 @@ main() {
expect(hover.elementDescription, 'A() → A');
expect(hover.elementKind, 'constructor');
// types
- expect(hover.staticType, 'A');
+ expect(hover.staticType, isNull);
expect(hover.propagatedType, isNull);
// no parameter
expect(hover.parameter, isNull);
@@ -300,7 +329,7 @@ main() {
expect(hover.elementDescription, 'A() → A<String>');
expect(hover.elementKind, 'constructor');
// types
- expect(hover.staticType, 'A<String>');
+ expect(hover.staticType, isNull);
expect(hover.propagatedType, isNull);
// no parameter
expect(hover.parameter, isNull);

Powered by Google App Engine
This is Rietveld 408576698