Skip the screenshot_sync test properly.

Skip the screenshot_sync test properly.

Use test expectations instead of the benchmark.Disabled annotation.

Signal a non-zero exit code from
run_telemetry_benchmark_as_googletest.py when the target script produces
no output. This will allow recipes to detect this failure case more
automatically.

BUG=459820, 561863
R=dpranke@chromium.org
TBR=bajones@chromium.org,nednguyen@google.com

Committed: https://crrev.com/34f722f157a6318525aa77817289937c0b5bb368
Cr-Commit-Position: refs/heads/master@{#364304}

[Ken Russell (switch to Gerrit), 2015-12-10 01:59:30]

Description was changed from

==========
Skip the screenshot_sync test properly.

Use test expectations instead the benchmark.Disabled annotation.

Signal a non-zero exit code from
run_telemetry_benchmark_as_googletest.py when the target script produces
no output. This will allow recipes to detect this failure case more
automatically.

BUG=459820,561863
==========

to

==========
Skip the screenshot_sync test properly.

Use test expectations instead of the benchmark.Disabled annotation.

Signal a non-zero exit code from
run_telemetry_benchmark_as_googletest.py when the target script produces
no output. This will allow recipes to detect this failure case more
automatically.

BUG=459820,561863
==========

[Ken Russell (switch to Gerrit), 2015-12-10 02:01:44]

kbr@chromium.org changed reviewers:
+ dpranke@chromium.org

[Ken Russell (switch to Gerrit), 2015-12-10 02:01:44]

dpranke: could you please review this?

I've tested it locally and ensured (1) that the
run_telemetry_benchmark_as_googletest.py change properly reports the
screenshot_sync failure with return code 1; and also that using the Skip test
expectation returns it to a working state with valid results and return code of
0.

Thanks. (bajones, nednguyen, planning to TBR this to you.)

[Dirk Pranke, 2015-12-10 02:03:56]

lgtm

[Ken Russell (switch to Gerrit), 2015-12-10 02:04:57]

Description was changed from

==========
Skip the screenshot_sync test properly.

Use test expectations instead of the benchmark.Disabled annotation.

Signal a non-zero exit code from
run_telemetry_benchmark_as_googletest.py when the target script produces
no output. This will allow recipes to detect this failure case more
automatically.

BUG=459820,561863
==========

to

==========
Skip the screenshot_sync test properly.

Use test expectations instead of the benchmark.Disabled annotation.

Signal a non-zero exit code from
run_telemetry_benchmark_as_googletest.py when the target script produces
no output. This will allow recipes to detect this failure case more
automatically.

BUG=459820,561863
R=dpranke@chromium.org
TBR=bajones@chromium.org,nednguyen@google.com
==========

[Ken Russell (switch to Gerrit), 2015-12-10 02:05:02]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2015-12-10 02:06:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1513943002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1513943002/1

[commit-bot: I haz the power, 2015-12-10 06:52:04]

Description was changed from

==========
Skip the screenshot_sync test properly.

Use test expectations instead of the benchmark.Disabled annotation.

Signal a non-zero exit code from
run_telemetry_benchmark_as_googletest.py when the target script produces
no output. This will allow recipes to detect this failure case more
automatically.

BUG=459820,561863
R=dpranke@chromium.org
TBR=bajones@chromium.org,nednguyen@google.com
==========

to

==========
Skip the screenshot_sync test properly.

Use test expectations instead of the benchmark.Disabled annotation.

Signal a non-zero exit code from
run_telemetry_benchmark_as_googletest.py when the target script produces
no output. This will allow recipes to detect this failure case more
automatically.

BUG=459820,561863
R=dpranke@chromium.org
TBR=bajones@chromium.org,nednguyen@google.com
==========

[commit-bot: I haz the power, 2015-12-10 06:52:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-10 06:52:49]

Description was changed from

==========
Skip the screenshot_sync test properly.

Use test expectations instead of the benchmark.Disabled annotation.

Signal a non-zero exit code from
run_telemetry_benchmark_as_googletest.py when the target script produces
no output. This will allow recipes to detect this failure case more
automatically.

BUG=459820,561863
R=dpranke@chromium.org
TBR=bajones@chromium.org,nednguyen@google.com
==========

to

==========
Skip the screenshot_sync test properly.

Use test expectations instead of the benchmark.Disabled annotation.

Signal a non-zero exit code from
run_telemetry_benchmark_as_googletest.py when the target script produces
no output. This will allow recipes to detect this failure case more
automatically.

BUG=459820,561863
R=dpranke@chromium.org
TBR=bajones@chromium.org,nednguyen@google.com

Committed: https://crrev.com/34f722f157a6318525aa77817289937c0b5bb368
Cr-Commit-Position: refs/heads/master@{#364304}
==========

[commit-bot: I haz the power, 2015-12-10 06:52:50]

Patchset 1 (id:??) landed as
https://crrev.com/34f722f157a6318525aa77817289937c0b5bb368
Cr-Commit-Position: refs/heads/master@{#364304}